Changeset 6970

Timestamp:

06/08/07 05:01:35 (1 year ago)

Author:

bitsweat

Message:

Action caching is limited to GET requests returning 200 OK status. Closes #3335.

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/caching.rb (modified) (1 diff)
• trunk/actionpack/test/controller/caching_test.rb (modified) (3 diffs)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Action caching is limited to GET requests returning 200 OK status.  #3335 [tom@craz8.com, halfbyte, Dan Kubb, Josh Peek]
-
-* Improve Text Helper test coverage.  #7274 [Rob Sanheim, Josh Peek]

trunk/actionpack/lib/action_controller/caching.rb

@@ -241 +241 @@
-
-        def after(controller)
-
+ || !caching_allowed(controller)
-          controller.write_fragment(controller.action_cache_path.path, controller.response.body)
-        end
-
+
-        private
-          
-          def set_content_type!(controller, extension)
-            controller.response.content_type = Mime::EXTENSION_LOOKUP[extension].to_s if extension
-          end
-
+
-          def path_options_for(controller, options)
-            ((path_options = options[:cache_path]).respond_to?(:call) ? path_options.call(controller) : path_options) || {}
-          end
-
+
+
+
+
-      end
-      

trunk/actionpack/test/controller/caching_test.rb

@@ -122 +122 @@
-
-class ActionCachingTestController < ActionController::Base
-
+, :redirected, :forbidden
-  caches_action :show, :cache_path => 'http://test.host/custom/show'
-  caches_action :edit, :cache_path => Proc.new { |c| c.params[:id] ? "http://test.host/#{c.params[:id]};edit" : "http://test.host/edit" }
@@ -130 +130 @@
-    render :text => @cache_this
-  end
-
+
+
+
+
+
+
+
+
+
+
-  alias_method :show, :index
-  alias_method :edit, :index
@@ -246 +255 @@
-  end
-
+  def test_redirect_is_not_cached
+    get :redirected
+    assert_response :redirect
+    reset!
+
+    get :redirected
+    assert_response :redirect
+  end
+
+  def test_forbidden_is_not_cached
+    get :forbidden
+    assert_response :forbidden
+    reset!
+
+    get :forbidden
+    assert_response :forbidden
+  end
+
-  def test_xml_version_of_resource_is_treated_as_different_cache
-    @mock_controller.mock_url_for = 'http://example.org/posts/'