Changeset 6882

Timestamp:

05/28/07 23:33:54 (1 year ago)

Author:

bitsweat

Message:

Multibyte strings respond_to the String methods they proxy so they can be duck-typed. Closes #6549.

Files:

• trunk/activesupport/CHANGELOG (modified) (2 diffs)
• trunk/activesupport/lib/active_support/multibyte/chars.rb (modified) (1 diff)
• trunk/activesupport/test/multibyte_chars_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Multibyte strings respond_to the String methods they proxy so they can be duck-typed.  #6549 [Tuxie]
-
-* Array#to_xml yields the builder just like Hash and ActiveRecord::Base.  #8472 [seth]
@@ -147 +149 @@
-* Make String#chars slicing behaviour consistent with String. Closes #6387 [Manfred Stienstra]
-
-
+t
-
-* Add ActiveSupport::Multibyte.  Provides String#chars which lets you deal with strings as a sequence of chars, not of bytes. Closes #6242 [Julian Tarkhanov, Manfred Stienstra, Thijs van der Vossen & Jan Behrens]

trunk/activesupport/lib/active_support/multibyte/chars.rb

@@ -40 +40 @@
-      # core dumps. Don't go there.
-      @string
+    end
+    
+    # Make duck-typing with String possible
+    def respond_to?(method)
+      super || @string.respond_to?(method) || handler.respond_to?(method) ||
+        (method.to_s =~ /(.*)!/ && handler.respond_to?($1)) || false
-    end
-    

trunk/activesupport/test/multibyte_chars_test.rb

@@ -152 +152 @@
-  end
-  
+  def test_duck_typing
+    assert_equal true,  'test'.chars.respond_to?(:strip)
+    assert_equal true,  'test'.chars.respond_to?(:normalize)
+    assert_equal true,  'test'.chars.respond_to?(:normalize!)
+    assert_equal false, 'test'.chars.respond_to?(:a_method_that_doesnt_exist)
+  end
+  
-  protected
-