Changeset 6657

Timestamp:

05/04/07 20:07:37 (1 year ago)

Author:

xal

Message:

Make respond_to? work as expected

Files:

• trunk/activeresource/lib/active_resource/base.rb (modified) (1 diff)
• trunk/activeresource/test/base_test.rb (modified) (1 diff)

trunk/activeresource/lib/active_resource/base.rb

@@ -317 +317 @@
-      self
-    end
+    
+    # For checking respond_to? without searching the attributes (which is faster).
+    alias_method :respond_to_without_attributes?, :respond_to?
+
+    # A Person object with a name attribute can ask person.respond_to?("name"), person.respond_to?("name="), and
+    # person.respond_to?("name?") which will all return true.
+    def respond_to?(method, include_priv = false)
+      method_name = method.to_s
+      if attributes.nil?
+        return super
+      elsif attributes.has_key?(method_name)
+        return true 
+      elsif ['?','='].include?(method_name.last) && attributes.has_key?(method_name.first(-1))
+        return true
+      end
+      # super must be called at the end of the method, because the inherited respond_to?
+      # would return true for generated readers, even if the attribute wasn't present
+      super
+    end
+    
-
-    protected

trunk/activeresource/test/base_test.rb

@@ -179 +179 @@
-    assert_equal "Matz", matz.name
-  end
+  
+  def test_respond_to
+    matz = Person.find(1)
+    assert matz.respond_to?(:name)
+    assert matz.respond_to?(:name=)
+    assert matz.respond_to?(:name?)
+    assert !matz.respond_to?(:java)
+  end
-
-  def test_find_by_id_with_custom_prefix