Changeset 6474

Timestamp:

03/27/07 17:53:52 (1 year ago)

Author:

madrobby

Message:

Fix Form.disable to work again on non-form elements. Closes #6887. [Mislav Marohnic]

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/form.js (modified) (2 diffs)
• spinoffs/prototype/trunk/test/unit/form.html (modified) (1 diff)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix Form.disable to work again on non-form elements.  Closes #6887.  [Mislav Marohnić]
-
-* Fix an issue with String.prototype.endsWith.  Closes #7822.  [altblue]

spinoffs/prototype/trunk/src/form.js

@@ -57 +57 @@
-  disable: function(form) {
-    form = $(form);
-
-
-
-
+
-    return form;
-  },
@@ -66 +63 @@
-  enable: function(form) {
-    form = $(form);
-
-
-
+
-    return form;
-  },

spinoffs/prototype/trunk/test/unit/form.html

@@ -185 +185 @@
-    }},
-    
+    testFormEnabling: function(){ with(this) {
+      var form = $('form_focus')
+      var input1 = form.focus_disabled
+      var input2 = form.focus_text
+      
+      assert(input1.disabled)
+      assert(!input2.disabled)
+      
+      form.disable()
+      assert(input1.disabled)
+      assert(input2.disabled)
+      
+      form.enable()
+      assert(!input1.disabled)
+      assert(!input2.disabled)
+      
+      input1.disable()
+      assert(input1.disabled)
+      
+      // non-form elements:
+      var fieldset = $('form_fieldset')
+      var fields = fieldset.immediateDescendants()
+      assert(fields.all(function(select){ return !select.disabled }))
+      
+      Form.disable(fieldset)
+      assert(fields.all(function(select){ return select.disabled }))
+      
+      Form.enable(fieldset)
+      assert(fields.all(function(select){ return !select.disabled }))
+    }},
+    
-    testFormElementEnabling: function(){ with(this) {
-      assert($('input_disabled').disabled);