Changeset 6440

Timestamp:

03/17/07 15:48:47 (1 year ago)

Author:

bitsweat

Message:

Base.update_all :order and :limit options. Useful for MySQL updates that must be ordered to avoid violating unique constraints.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/base.rb (modified) (1 diff)
• trunk/activerecord/test/base_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Base.update_all :order and :limit options. Useful for MySQL updates that must be ordered to avoid violating unique constraints.  [Jeremy Kemper]
-
-* Remove deprecated object transactions.  People relying on this functionality should install the object_transactions plugin at http://code.bitsweat.net/svn/object_transactions.  Closes #5637 [Koz, Jeremy Kemper]

trunk/activerecord/lib/active_record/base.rb

@@ -502 +502 @@
-      # A subset of the records can be selected by specifying +conditions+. Example:
-      #   Billing.update_all "category = 'authorized', approved = 1", "author = 'David'"
-
+
+
+
+
-        sql  = "UPDATE #{table_name} SET #{sanitize_sql_for_assignment(updates)} "
-
+
+
+
+
-        connection.update(sql, "#{name} Update")
-      end

trunk/activerecord/test/base_test.rb

@@ -570 +570 @@
-  end
-
+  if current_adapter?(:MysqlAdapter)
+    def test_update_all_with_order_and_limit
+      assert_equal 1, Topic.update_all("content = 'bulk updated!'", nil, :limit => 1, :order => 'id DESC')
+    end
+  end
+
-  def test_update_many
-    topic_data = { 1 => { "content" => "1 updated" }, 2 => { "content" => "2 updated" } }