Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 6339

Show
Ignore:
Timestamp:
03/05/07 17:32:16 (2 years ago)
Author:
minam
Message:

Don't send no-auth-cache if no auth credentials are given

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • branches/capistrano_1-x-stable/CHANGELOG

    r6219 r6339  
     1*SVN* 
     2 
     3* Don't send no-auth-cache if no auth credentials are given [Jonathan Younger] 
     4 
    15*1.4.1* (February 24, 2007) 
    26 
    3 * Use the no-auth-cache option with subversion so that username/password tokens do not get cached by capistrano usage [jonathan] 
     7* Use the no-auth-cache option with subversion so that username/password tokens do not get cached by capistrano usage [Jonathan Younger] 
    48 
    59* Deprecated upper-cased variables [Jamis Buck] 

  • branches/capistrano_1-x-stable/lib/capistrano/scm/subversion.rb

    r6218 r6339  
    8181          username = configuration[:svn_username] ? "--username #{configuration[:svn_username]}" : "" 
    8282          password = configuration[:svn_password] ? "--password #{configuration[:svn_password]}" : "" 
    83           "--no-auth-cache #{username} #{password}" 
     83          no_auth_cache = configuration[:svn_username] || configuration[:svn_password] ? "--no-auth-cache" : "" 
     84          "#{no_auth_cache} #{username} #{password}" 
    8485        end 
    8586 

  • branches/capistrano_1-x-stable/test/scm/subversion_test.rb

    r6218 r6339  
    135135    assert_match %r{/path/to/svn\b.*\bco\b.* --username turtledove}, @actor.command 
    136136  end 
     137   
     138  def test_svn_no_auth_cache 
     139    @actor.story = [] 
     140    @config[:svn_username] = "turtledove" 
     141    assert_nothing_raised { @scm.checkout(@actor) } 
     142    assert_nil @actor.channels.last.sent_data 
     143    assert_match %r{/path/to/svn\b.*\bco\b.* --no-auth-cache --username turtledove}, @actor.command 
     144  end 
    137145end