Changeset 6064

Timestamp:

01/28/07 08:49:23 (2 years ago)

Author:

bitsweat

Message:

MySQL: SET SQL_AUTO_IS_NULL=0 so 'where id is null' doesn't select the last inserted id. Closes #6778.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb (modified) (1 diff)
• trunk/activerecord/test/finder_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* MySQL: SET SQL_AUTO_IS_NULL=0 so 'where id is null' doesn't select the last inserted id.  #6778 [Jonathan Viney, timc]
-
-* Use Date#to_s(:db) for quoted dates.  #7411 [Michael Schoen]

trunk/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb

@@ -389 +389 @@
-          @connection.real_connect(*@connection_options)
-          execute("SET NAMES '#{encoding}'") if encoding
+
+          # By default, MySQL 'where id is null' selects the last inserted id.
+          # Turn this off. http://dev.rubyonrails.org/ticket/6778
+          execute("SET SQL_AUTO_IS_NULL=0")
-        end
-

trunk/activerecord/test/finder_test.rb

@@ -461 +461 @@
-  end
-
+  # http://dev.rubyonrails.org/ticket/6778
+  def test_find_ignores_previously_inserted_record
+    post = Post.create!
+    assert_equal [], Post.find_all_by_id(nil)
+  end
+
-  def test_find_by_empty_ids
-    assert_equal [], Post.find([])