Changeset 5416

Timestamp:

11/02/06 20:20:46 (2 years ago)

Author:

bitsweat

Message:

Dynamically generate reader methods for serialized attributes. Closes #6362.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/base.rb (modified) (2 diffs)
• trunk/activerecord/test/base_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Dynamically generate reader methods for serialized attributes.  #6362 [Stefan Kaes]
-
-* Deprecation: object transactions warning.  [Jeremy Kemper]

trunk/activerecord/lib/active_record/base.rb

@@ -1875 +1875 @@
-      def define_read_methods
-        self.class.columns_hash.each do |name, column|
-
-
-
+
+
+
+
+
+
+
+
+
+
-          end
-        end
@@ -1895 +1902 @@
-      end
-      
+      # Define read method for serialized attribute.
+      def define_read_method_for_serialized_attribute(attr_name)
+        unless attr_name.to_s == self.class.primary_key.to_s
+          self.class.read_methods << attr_name
+        end
+        
+        evaluate_read_method attr_name, "def #{attr_name}; unserialize_attribute('#{attr_name}'); end"
+      end
+           
-      # Define an attribute ? method.
-      def define_question_method(attr_name)

trunk/activerecord/test/base_test.rb

@@ -1477 +1477 @@
-  private
-    def assert_readers(model, exceptions)
-(model.serialized_attributes.keys + ['id'])
+['id']
-      expected_readers += expected_readers.map { |col| "#{col}?" }
-      expected_readers -= exceptions