Changeset 5091

Timestamp:

09/12/06 07:10:43 (2 years ago)

Author:

bitsweat

Message:

alias_method_chain works with accessor= methods also. Closes #6153.

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/module/aliasing.rb (modified) (1 diff)
• trunk/activesupport/test/core_ext/module_test.rb (modified) (3 diffs)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* alias_method_chain works with accessor= methods also.  #6153 [Caio Chassot]
-
-* Fix loadable_constants_for_path to handle load paths that do not end with a slash. [Nicholas Seckar]

trunk/activesupport/lib/active_support/core_ext/module/aliasing.rb

@@ -24 +24 @@
-    # Strip out punctuation on predicates or bang methods since
-    # e.g. target?_without_feature is not a valid method name.
-
+=
-    alias_method "#{aliased_target}_without_#{feature}#{punctuation}", target
-    alias_method target, "#{aliased_target}_with_#{feature}#{punctuation}"

trunk/activesupport/test/core_ext/module_test.rb

@@ -109 +109 @@
-
-  def quux_with_baz!
-!
+
-  end
-
-  def quux_with_baz?
-    false
+  end
+
+  def quux_with_baz=(v)
+    send(:quux_without_baz=, v) << '_with_baz'
-  end
-end
@@ -155 +159 @@
-    assert @instance.respond_to?(:quux_with_baz!)
-
-!
+
-    assert_equal 'quux', @instance.quux_without_baz!
-  end
-
-  def test_alias_method_chain_with_same_names_between_predicates_and_bang_methods
-
+!
-    FooClassWithBarMethod.send(:define_method, 'quux?', Proc.new { true })
+    FooClassWithBarMethod.send(:define_method, 'quux=', Proc.new { 'quux=' })
-    assert !@instance.respond_to?(:quux_with_baz!)
-    assert !@instance.respond_to?(:quux_with_baz?)
-
-
-
-
-
+
+
+
-    assert @instance.respond_to?(:quux_with_baz!)
-    assert @instance.respond_to?(:quux_with_baz?)
-
-
+
+
+
+
+
+
+
+
-    assert_equal false, @instance.quux?
-    assert_equal true,  @instance.quux_without_baz?
+
+    FooClassWithBarMethod.alias_method_chain :quux=, :baz
+    assert_equal 'quux=_with_baz', @instance.send(:quux=, 1234)
+    assert_equal 'quux=', @instance.send(:quux_without_baz=, 1234)
-  end
-
@@ -184 +197 @@
-    FooClassWithBarMethod.alias_method_chain :quux, :baz!
-    assert_nothing_raised do
-!
+
-    end
-