Changeset 5075

Timestamp:

09/08/06 22:01:00 (3 years ago)

Author:

david

Message:

We cant make MySQL 5 happy if it means making SQLite and PostgreSQL cry. So currently MySQL 5 is not fully supported for Rails when youre using eager loading (closes #6133, #6135). I have contacted MySQL to make them fix http://bugs.mysql.com/bug.php?id=13551 [DHH]

Files:

• trunk/actionpack/lib/action_view/helpers/form_helper.rb (modified) (1 diff)
• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/associations.rb (modified) (1 diff)
• trunk/activerecord/lib/active_record/base.rb (modified) (1 diff)

trunk/actionpack/lib/action_view/helpers/form_helper.rb

@@ -413 +413 @@
-      self.field_helpers = (FormHelper.instance_methods - ['form_for'])
-
-
+, :options
-
-      def initialize(object_name, object, template, options, proc)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
-
-* Added parentheses around FROM clauses generated by Base and associations since MySQL 5 claim that to be the standard (and will screw up joins if its not there), see http://bugs.mysql.com/bug.php?id=13551 [DHH]
-
-* Rename AR::Base#quote so people can use that name in their models. #3628 [Koz]

trunk/activerecord/lib/active_record/associations.rb

@@ -1132 +1132 @@
-        def construct_finder_sql_with_included_associations(options, join_dependency)
-          scope = scope(:find)
-(#{(scope && scope[:from]) || options[:from] || table_name})
+#{(scope && scope[:from]) || options[:from] || table_name}
-          sql << join_dependency.join_associations.collect{|join| join.association_join }.join
- 

trunk/activerecord/lib/active_record/base.rb

@@ -1090 +1090 @@
-          scope = scope(:find)
-          sql  = "SELECT #{(scope && scope[:select]) || options[:select] || '*'} "
-(#{(scope && scope[:from]) || options[:from] || table_name})
+#{(scope && scope[:from]) || options[:from] || table_name}
-
-          add_joins!(sql, options, scope)