Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 5050

Show
Ignore:
Timestamp:
09/06/06 11:19:00 (2 years ago)
Author:
madrobby
Message:

script.aculo.us: Fix an issue with Draggables when no options are supplied, fixes #6045 [thx tdd]

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • spinoffs/scriptaculous/CHANGELOG

    r5049 r5050  
    1 *V1.6.4* 
     1* Fix an issue with Draggables when no options are supplied, fixes #6045 [thx tdd] 
     2 
     3*V1.6.4* (September 6, 2006) 
    24 
    35* Hotfix IE issues with patched Prototype V1.5.0_rc1 
    46 
    5 *V1.6.3* 
     7*V1.6.3* (September 5, 2006) 
    68 
    79* Update Prototype to V1.5.0_rc1 

  • spinoffs/scriptaculous/src/dragdrop.js

    r4921 r5050  
    252252    }; 
    253253     
    254     if(arguments[1] && typeof arguments[1].endeffect == 'undefined') 
     254    if(!arguments[1] || typeof arguments[1].endeffect == 'undefined') 
    255255      Object.extend(defaults, { 
    256256        starteffect: function(element) { 

  • spinoffs/scriptaculous/test/unit/dragdrop_test.html

    r3141 r5050  
    2626 
    2727<p id="p_test">p_test</p> 
     28<p id="p_test2">p_test2</p> 
     29<p id="p_test3">p_test3</p> 
    2830<img id="img_test" src="icon.png" alt="img_text"/> 
    2931<div id="droppable_test">droppable_test</div> 
    …… 
    5153      var d = new Draggable('p_test'); 
    5254      assertInstanceOf(Draggable, d); 
    53        
    54        
     55    }}, 
     56 
     57    testDraggableStartEffect: function() { with(this) { 
     58      var d = new Draggable('p_test2'); 
     59      assert(d.options.starteffect, 'There should be a default start effect.'); 
     60      d = new Draggable('p_test3', { endeffect: Prototype.EmptyFunction }); 
     61      assert(undefined === d.options.startEffect, 'There should be no default start effect.'); 
    5562    }}, 
    5663