Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 4962

Show
Ignore:
Timestamp:
09/04/06 03:07:17 (2 years ago)
Author:
bitsweat
Message:

Active Record integration deprecation tests

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/actionpack/lib/action_controller/assertions/deprecated_assertions.rb

    r4938 r4962  
    216216 
    217217        def find_record_in_template(key = nil) 
    218           assert_template_has(key) 
     218          assert_not_nil assigns(key) 
    219219          record = @response.template_objects[key] 
    220220 
     
    223223 
    224224          return record 
    225         end       
     225        end 
    226226    end 
    227227  end 
  • trunk/actionpack/test/activerecord/active_record_assertions_test.rb

    r4807 r4962  
    5151  def test_some_invalid_columns 
    5252    process :nasty_columns_1 
    53     assert_success 
    54     assert_invalid_record 'company' 
    55     assert_invalid_column_on_record 'company', 'rating' 
    56     assert_valid_column_on_record 'company', 'name' 
    57     assert_valid_column_on_record 'company', %w(name id) 
     53    assert_response :success 
     54 
     55    assert_deprecated_assertion { assert_invalid_record 'company' } 
     56    assert_deprecated_assertion { assert_invalid_column_on_record 'company', 'rating' } 
     57    assert_deprecated_assertion { assert_valid_column_on_record 'company', 'name' } 
     58    assert_deprecated_assertion { assert_valid_column_on_record 'company', %w(name id) } 
    5859  end 
    5960 
     
    6162  def test_all_invalid_columns 
    6263    process :nasty_columns_2 
    63     assert_success 
    64     assert_invalid_record 'company' 
    65     assert_invalid_column_on_record 'company', 'rating' 
    66     assert_invalid_column_on_record 'company', 'name' 
    67     assert_invalid_column_on_record 'company', %w(name rating) 
     64    assert_response :success 
     65 
     66    assert_deprecated_assertion { assert_invalid_record 'company' } 
     67    assert_deprecated_assertion { assert_invalid_column_on_record 'company', 'rating' } 
     68    assert_deprecated_assertion { assert_invalid_column_on_record 'company', 'name' } 
     69    assert_deprecated_assertion { assert_invalid_column_on_record 'company', %w(name rating) } 
    6870  end 
    6971 
     
    7173  def test_valid_record 
    7274    process :good_company 
    73     assert_success 
    74     assert_valid_record 'company' 
     75    assert_response :success 
     76 
     77    assert_deprecated_assertion { assert_valid_record 'company' } 
    7578  end 
    7679 
     
    7881  def test_invalid_record 
    7982    process :bad_company 
    80     assert_success 
    81     assert_invalid_record 'company' 
     83    assert_response :success 
     84 
     85    assert_deprecated_assertion { assert_invalid_record 'company' } 
    8286  end 
     87 
     88  protected 
     89    def assert_deprecated_assertion(message = nil, &block) 
     90      assert_deprecated(/assert_.*from test_/, &block) 
     91    end 
    8392end