Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 4839

Show
Ignore:
Timestamp:
08/29/06 08:24:04 (2 years ago)
Author:
bitsweat
Message:

Eliminate Active Support warnings.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/activesupport/lib/active_support/core_ext/module/attr_internal.rb

    r4692 r4839  
    1616  # Declare attributes backed by 'internal' instance variables names. 
    1717  def attr_internal_accessor(*attrs) 
    18     attr_internal_reader *attrs 
    19     attr_internal_writer *attrs 
     18    attr_internal_reader(*attrs) 
     19    attr_internal_writer(*attrs) 
    2020  end 
    2121 

  • trunk/activesupport/lib/active_support/deprecation.rb

    r4760 r4839  
    1919      # Have deprecations been silenced? 
    2020      def silenced? 
     21        @silenced = false unless defined?(@silenced) 
    2122        @silenced 
    2223      end 

  • trunk/activesupport/lib/active_support/vendor/builder/xmlbase.rb

    r4260 r4839  
    5454          raise ArgumentError, "XmlMarkup cannot mix a text argument with a block" 
    5555        end 
    56         _capture_outer_self(block) if @self.nil? 
     56        _capture_outer_self(block) unless defined?(@self) && !@self.nil? 
    5757        _indent 
    5858        _start_tag(sym, attrs) 

  • trunk/activesupport/Rakefile

    r4321 r4839  
    1919  t.pattern = 'test/**/*_test.rb' 
    2020  t.verbose = true 
    21   t.warning = false 
     21  t.warning = true 
    2222} 
    2323 

  • trunk/activesupport/test/core_ext/name_error_test.rb

    r4681 r4839  
    1 require 'test/unit' 
    2 require File.dirname(__FILE__) + '/../../lib/active_support/core_ext/name_error' 
     1require File.dirname(__FILE__) + '/../abstract_unit' 
    32 
    43class NameErrorTest < Test::Unit::TestCase 
    5    
    64  def test_name_error_should_set_missing_name 
    75    begin 
    …… 
    1412    end 
    1513  end 
    16    
     14 
    1715  def test_missing_method_should_ignore_missing_name 
    1816    begin 
    …… 
    2422    end 
    2523  end 
    26    
    2724end 

  • trunk/activesupport/test/core_ext/object_and_class_ext_test.rb

    r4595 r4839  
    7979    assert foo.extended_by.include?(Bar) 
    8080    foo.extend(Baz) 
    81     assert ([Bar, Baz] - foo.extended_by).empty?, "Expected Bar, Baz in #{foo.extended_by.inspect}" 
     81    assert(([Bar, Baz] - foo.extended_by).empty?, "Expected Bar, Baz in #{foo.extended_by.inspect}") 
    8282  end 
    8383