Changeset 4797

Timestamp:

08/20/06 20:02:13 (2 years ago)

Author:

madrobby

Message:

Fix an issue with redrawing ghosted draggables that are inside a scrolled container, fixes #3860 [thx gkupps, tsukue]

Files:

• spinoffs/scriptaculous/CHANGELOG (modified) (1 diff)
• spinoffs/scriptaculous/src/dragdrop.js (modified) (1 diff)
• spinoffs/scriptaculous/test/functional/dragdrop4_test.html (modified) (1 diff)
• spinoffs/scriptaculous/test/functional/dragdrop8_test.html (added)
• spinoffs/scriptaculous/test/functional/index.html (modified) (1 diff)

spinoffs/scriptaculous/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix an issue with redrawing ghosted draggables that are inside a scrolled container, fixes #3860 [thx gkupps, tsukue]
-
-* Added a custom exception to all base effects when used on non-existing DOM elements, added a assertRaise method to unit tests

spinoffs/scriptaculous/src/dragdrop.js

@@ -426 +426 @@
-  draw: function(point) {
-    var pos = Position.cumulativeOffset(this.element);
+    if(this.options.ghosting) {
+      Position.prepare();
+      var r   = Position.realOffset(this.element);
+      window.status = r.inspect();
+      pos[0] += r[0] - Position.deltaX; pos[1] += r[1] - Position.deltaY;
+    }
+    
-    var d = this.currentDelta();
-    pos[0] -= d[0]; pos[1] -= d[1];

spinoffs/scriptaculous/test/functional/dragdrop4_test.html

@@ -31 +31 @@
-<script type="text/javascript" language="javascript" charset="utf-8">
-// <![CDATA[
+  Position.includeScrollOffsets = true;
+
-  new Draggable('absolute_positioned_element',{ghosting: true});
-  new Draggable('absolute_positioned_element2',{ghosting: true, revert:true});

spinoffs/scriptaculous/test/functional/index.html

@@ -43 +43 @@
-  <li><a href="dragdrop6_test.html" target="test">dragdrop6_test: snap option</a></li>
-  <li><a href="dragdrop7_test.html" target="test">dragdrop7_test</a></li>
+  <li><a href="dragdrop8_test.html" target="test">dragdrop8_test</a></li>
-</ul>
-<ul>