Changeset 4650

Timestamp:

08/02/06 20:20:38 (4 years ago)

Author:

bitsweat

Message:

Schema dumper quotes date :default values.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/schema_dumper.rb (modified) (2 diffs)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Schema dumper quotes date :default values. [Dave Thomas]
-
-* Calculate sum with SQL, not Enumerable on HasManyThrough Associations. [Dan Peterson]

trunk/activerecord/lib/active_record/schema_dumper.rb

@@ -96 +96 @@
-            spec[:scale] = column.scale.inspect if !column.scale.nil?
-            spec[:null]    = 'false' if !column.null
-(column.default.is_a?(BigDecimal) ? column.default.to_s : column.default.inspec
+default_string(column.defaul
-            (spec.keys - [:name, :type]).each{ |k| spec[k].insert(0, "#{k.inspect} => ")}
-            spec
@@ -126 +126 @@
-      end
-
+      def default_string(value)
+        case value
+        when BigDecimal
+          value.to_s
+        when Date, DateTime, Time
+          "'" + value.to_s(:db) + "'"
+        else
+          value.inspect
+        end
+      end
+      
-      def indexes(table, stream)
-        indexes = @connection.indexes(table)