Changeset 4482

Timestamp:

06/21/06 20:40:14 (2 years ago)

Author:

bitsweat

Message:

alias_method_chain preserves method punctuation so foo, foo?, and foo! may be chained with the same feature.

Files:

• trunk/activerecord/lib/active_record/validations.rb (modified) (1 diff)
• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/module/aliasing.rb (modified) (1 diff)

trunk/activerecord/lib/active_record/validations.rb

@@ -219 +219 @@
-      base.class_eval do
-        alias_method_chain :save, :validation
-!       
+
-        alias_method_chain :update_attribute, :validation_skipping
-      end

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* alias_method_chain preserves method punctuation so foo, foo?, and foo! may be chained with the same feature. [Jeremy Kemper]
+    Example:
+      alias_method_chain :save!, :validation
+    is equivalent to
+      alias_method :save_without_validation!, :save!
+      alias_method :save!, :save_with_validation!
-
-* Enhance Symbol#to_proc so it works with list objects, such as multi-dimensional arrays. Closes #5295 [nov@yo.rim.or.jp].  Example:

trunk/activesupport/lib/active_support/core_ext/module/aliasing.rb

@@ -10 +10 @@
-  #
-  # And both aliases are set up for you.
+  #
+  # Query and bang methods (foo?, foo!) keep the same punctuation:
+  #
+  #   alias_method_chain :foo?, :feature
+  #
+  # is equivalent to
+  #
+  #   alias_method :foo_without_feature?, :foo?
+  #   alias_method :foo?, :foo_without_feature?
+  #
+  # so you can safely chain foo, foo?, and foo! with the same feature.
-  def alias_method_chain(target, feature)
-    # Strip out punctuation on predicates or bang methods since
-    # e.g. target?_without_feature is not a valid method name.
- = target.to_s.sub(/[?!]/, '')
-
-
+, punctuation = target.to_s.sub(/([?!])$/, ''), $1
+#{punctuation}
+#{punctuation}
-  end
-end