Changeset 4459

Timestamp:

06/19/06 16:45:34 (2 years ago)

Author:

ulysses

Message:

Change AR::Base#to_param to return a String instead of a Fixnum. Closes #5320.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/base.rb (modified) (1 diff)
• trunk/activerecord/test/base_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Change AR::Base#to_param to return a String instead of a Fixnum. Closes #5320. [Nicholas Seckar]
-
-* Use explicit delegation instead of method aliasing for AR::Base.to_param -> AR::Base.id. #5299 (skaes@web.de)

trunk/activerecord/lib/active_record/base.rb

@@ -1411 +1411 @@
-      # Enables Active Record objects to be used as URL parameters in Action Pack automatically.
-      def to_param
-can't use alias_method here, because method 'id' optimizes itself on the fly
-
+We can't use alias_method here, because method 'id' optimizes itself on the fly.
+.to_s if id # Be sure to stringify the id for routes
-      end
-

trunk/activerecord/test/base_test.rb

@@ -1317 +1317 @@
-    assert_equal '::Person', ActiveRecord::Base.send(:type_name_with_module, '::Person')
-  end
+  
+  def test_to_param_should_return_string
+    assert_kind_of String, Client.find(:first).to_param
+  end
-
-  # FIXME: this test ought to run, but it needs to run sandboxed so that it