Changeset 4371

Timestamp:

05/28/06 01:04:27 (2 years ago)

Author:

david

Message:

Expanded :method option in FormHelper#form_tag to allow for verbs other than GET and POST by automatically creating a hidden form field named _method, which will simulate the other verbs over post [DHH]

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_view/helpers/form_tag_helper.rb (modified) (1 diff)
• trunk/actionpack/test/template/form_helper_test.rb (modified) (1 diff)
• trunk/actionpack/test/template/form_tag_helper_test.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Expanded :method option in FormHelper#form_tag to allow for verbs other than GET and POST by automatically creating a hidden form field named _method, which will simulate the other verbs over post [DHH]
-
-* Added :method option to UrlHelper#link_to, which allows for using other verbs than GET for the link. This replaces the :post option, which is now deprecated. Example: link_to "Destroy", person_url(:id => person), :method => :delete [DHH]

trunk/actionpack/lib/action_view/helpers/form_tag_helper.rb

@@ -15 +15 @@
-      # Options:
-      # * <tt>:multipart</tt> - If set to true, the enctype is set to "multipart/form-data".
-
+
+
+
-      def form_tag(url_for_options = {}, options = {}, *parameters_for_url, &proc)
-{ "method" => "post" }.merge(options.stringify_keys)
+options.stringify_keys
-        html_options["enctype"] = "multipart/form-data" if html_options.delete("multipart")
-        html_options["action"] = url_for(url_for_options, *parameters_for_url)
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-      end
-

trunk/actionpack/test/template/form_helper_test.rb

@@ -231 +231 @@
-    expected = 
-      "<form action='http://www.example.com' id='create-post' method='post'>" +
+      "<input name='post[title]' size='30' type='text' id='post_title' value='Hello World' />" +
+      "<textarea name='post[body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
+      "<input name='post[secret]' checked='checked' type='checkbox' id='post_secret' value='1' />" +
+      "<input name='post[secret]' type='hidden' value='0' />" +
+      "</form>"
+
+    assert_dom_equal expected, _erbout
+  end
+
+  def test_form_for_with_method
+    _erbout = ''
+
+    form_for(:post, @post, :html => { :id => 'create-post', :method => :put }) do |f|
+      _erbout.concat f.text_field(:title)
+      _erbout.concat f.text_area(:body)
+      _erbout.concat f.check_box(:secret)
+    end
+
+    expected = 
+      "<form action='http://www.example.com' id='create-post' method='post'>" +
+      "<input name='_method' type='hidden' value='put' />" +
-      "<input name='post[title]' size='30' type='text' id='post_title' value='Hello World' />" +
-      "<textarea name='post[body]' id='post_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +

trunk/actionpack/test/template/form_tag_helper_test.rb

@@ -31 +31 @@
-    actual = form_tag({}, { 'multipart' => true })
-    expected = %(<form action="http://www.example.com" enctype="multipart/form-data" method="post">)
+    assert_dom_equal expected, actual
+  end
+
+  def test_form_tag_with_method
+    actual = form_tag({}, { :method => :put })
+    expected = %(<form action="http://www.example.com" method="post"><input type="hidden" name="_method" value="put" />)
-    assert_dom_equal expected, actual
-  end