Changeset 4343

Timestamp:

05/16/06 20:56:41 (2 years ago)

Author:

nzkoz

Message:

Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/cgi_ext/cgi_methods.rb (modified) (1 diff)
• trunk/actionpack/test/controller/cgi_test.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix NoMethodError when parsing params like &&. [Adam Greenfield]
-
-* Fix flip flopped logic in docs for url_for's :only_path option. Closes #4998. [esad@esse.at]

trunk/actionpack/lib/action_controller/cgi_ext/cgi_methods.rb

@@ -46 +46 @@
-
-      for key, value in params
+        next if key.nil?
-        value = [value] if key =~ /.*\[\]$/
-        unless key.include?('[')

trunk/actionpack/test/controller/cgi_test.rb

@@ -228 +228 @@
-    assert_equal expected, CGIMethods.parse_request_parameters(input)
-  end
+  
+  def test_parse_params_with_nil_key
+    input = { nil => nil, "test2" => %w(value1) }
+    expected = { "test2" => "value1" }
+    assert_equal expected, CGIMethods.parse_request_parameters(input)
+  end
-end
-