Changeset 4094

Timestamp:

03/29/06 00:00:29 (3 years ago)

Author:

sam

Message:

prototype: Cache methods added to DOM elements with Element.extend to prevent memory leaks in IE. Closes #4465.

Files:

• spinoffs/prototype/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/src/dom.js (modified) (2 diffs)

spinoffs/prototype/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Cache methods added to DOM elements with Element.extend to prevent memory leaks in IE. Closes #4465. [jaen@laborint.com, sam]
-
-* 1.5.0_pre1* (March 26, 2006)

spinoffs/prototype/src/dom.js

@@ -28 +28 @@
-  
-  if (!element._extended && element.tagName && element != window) {
-
+, cache = Element.extend.cache
-    for (property in methods) {
-      var value = methods[property];
-      if (typeof value == 'function')
-value.bind(null, element
+cache.findOrStore(value
-    }
-  }
@@ -38 +38 @@
-  element._extended = true;
-  return element;
+}
+
+Element.extend.cache = {
+  findOrStore: function(value) {
+    return this[value] = this[value] || function() {
+      return value.apply(null, [this].concat($A(arguments)));
+    }
+  }
-}
-