Changeset 3801

Timestamp:

03/06/06 19:45:02 (3 years ago)

Author:

david

Message:

Allow method chaining in RJS elements [Rick Olson]

Files:

• trunk/actionpack/lib/action_view/helpers/javascripts/dragdrop.js (modified) (1 diff)
• trunk/actionpack/lib/action_view/helpers/javascripts/effects.js (modified) (1 diff)
• trunk/actionpack/Rakefile (modified) (1 diff)
• trunk/railties/html/javascripts/effects.js (modified) (1 diff)

trunk/actionpack/lib/action_view/helpers/javascripts/dragdrop.js

@@ -559 +559 @@
-    if(!element.hasChildNodes()) return null;
-    var elements = [];
+    var only = options.only ? [options.only].flatten() : null;
-    $A(element.childNodes).each( function(e) {
-      if(e.tagName && e.tagName.toUpperCase()==options.tag.toUpperCase() &&
-ptions.only || (Element.hasClassName(e, options.only
+nly || (Element.classNames(e).detect(function(v) { return only.include(v) }
-          elements.push(e);
-      if(options.tree) {

trunk/actionpack/lib/action_view/helpers/javascripts/effects.js

@@ -919 +919 @@
-  }}, arguments[1] || {}));
-}
+
+if(Element.Methods) {
+  Element.Methods.visualEffect = function(element, effect, options) {
+    s = effect.gsub(/_/, '-').camelize();
+    effect_class = s.charAt(0).toUpperCase() + s.substring(1);
+    new Effect[effect_class](element, options);
+    return $(element);
+  }
+}

trunk/actionpack/Rakefile

@@ -117 +117 @@
-task :update_scriptaculous do
-  for js in %w( controls dragdrop effects )
- #{File.dirname(__FILE__)}/lib/action_view/helpers/javascripts/
+.js #{File.dirname(__FILE__)}/lib/action_view/helpers/javascripts/#{js}.js
-  end
-end

trunk/railties/html/javascripts/effects.js

@@ -919 +919 @@
-  }}, arguments[1] || {}));
-}
+
+if(Element.Methods) {
+  Element.Methods.visualEffect = function(element, effect, options) {
+    s = effect.gsub(/_/, '-').camelize();
+    effect_class = s.charAt(0).toUpperCase() + s.substring(1);
+    new Effect[effect_class](element, options);
+    return $(element);
+  }
+}