Changeset 3753

Timestamp:

03/03/06 06:25:39 (4 years ago)

Author:

david

Message:

Fixed that calling HasOneProxy#build_model repeatedly would cause saving to happen (closes #4058) [anna@wota.jp]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/associations/has_one_association.rb (modified) (1 diff)
• trunk/activerecord/test/associations_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fixed that calling HasOneProxy#build_model repeatedly would cause saving to happen #4058 [anna@wota.jp]
-
-* Added Sybase database adapter that relies on the Sybase Open Client bindings (see http://raa.ruby-lang.org/project/sybase-ctlib) #3765 [John Sheets]. It's almost completely Active Record compliant, but has the following caveats:

trunk/activerecord/lib/active_record/associations/has_one_association.rb

@@ -35 +35 @@
-          else
-            @target[@reflection.primary_key_name] = nil
-
+ || @target.new_record?
-          end
-        end

trunk/activerecord/test/associations_test.rb

@@ -157 +157 @@
-    assert !account.save
-    assert_equal "can't be empty", account.errors.on("credit_limit")
+  end
+
+  def test_build_association_twice_without_saving_affects_nothing
+    count_of_account = Account.count
+    firm = Firm.find(:first)
+    account1 = firm.build_account("credit_limit" => 1000)
+    account2 = firm.build_account("credit_limit" => 2000)
+
+    assert_equal count_of_account, Account.count
-  end
-