Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 370

Show
Ignore:
Timestamp:
01/10/05 22:46:45 (4 years ago)
Author:
david
Message:

Fixed three issues with retrying breakpoints #417 [Florian Gross]

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/actionpack/CHANGELOG

    r364 r370  
    11*SVN* 
     2 
     3* Fixed three issues with retrying breakpoints #417 [Florian Gross] 
     4 
     5  1. Don't screw up pages that use multiple values for the same parameter (?foo=bar&foo=qux was converted to ?foo=barqux)  
     6  2. Don't screw up all forms when you click the "Retry with Breakpoint" link multiple times instead of reloading  
     7     (This caused the parameters to be added multiple times for GET forms leading to trouble.)  
     8  3. Don't add ?BP-RETRY=1 multiple times 
    29 
    310* Added that all renders and redirects now return false, so they can be used as the last line in before_filters to stop execution. 
  • trunk/actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml

    r211 r370  
    11<% if defined?(Breakpoint) %> 
    22  <br /><br /> 
    3   <%= form_tag({}, "method" => @request.method) %> 
     3  <%= form_tag({:params => {}, :only_path => true}, "method" => @request.method) %> 
    44    <input type="hidden" name="BP-RETRY" value="1" /> 
    5  
    6     <% for key, value in @request.params %> 
    7       <input type="hidden" name="<%= key %>" value="<%= value %>" /> 
     5   
     6    <% for key, values in @params %> 
     7      <% next if key == "BP-RETRY" %> 
     8      <% for value in Array(values) %> 
     9        <input type="hidden" name="<%= key %>" value="<%= value %>" /> 
     10      <% end %> 
    811    <% end %> 
    912