Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Changeset 3533

Show
Ignore:
Timestamp:
02/04/06 06:11:42 (3 years ago)
Author:
david
Message:

Just go with Subclasses instead of OnlySubclasses

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/actionpack/lib/action_controller/caching.rb

    r3529 r3533  
    524524        # ActiveRecord::Observer will mark this class as reloadable even though it should not be. 
    525525        # However, subclasses of ActionController::Caching::Sweeper should be Reloadable 
    526         include Reloadable::OnlySubclasses 
     526        include Reloadable::Subclasses 
    527527         
    528528        def before(controller) 
  • trunk/activerecord/lib/active_record/base.rb

    r3523 r3533  
    244244    cattr_accessor :logger 
    245245     
    246     include Reloadable::OnlySubclasses 
     246    include Reloadable::Subclasses 
    247247     
    248248    def self.inherited(child) #:nodoc: 
     
    440440        else 
    441441          object = new(attributes) 
    442           if scoped?(:create) 
    443             scope(:create).each { |att,value| object.send("#{att}=", value) } 
    444           end 
     442          scope(:create).each { |att,value| object.send("#{att}=", value) } if scoped?(:create) 
    445443          object.save 
    446444          object 
  • trunk/activesupport/lib/active_support/reloadable.rb

    r3527 r3533  
    2020  # Captures the common pattern where a base class should not be reloaded, 
    2121  # but its subclasses should be. 
    22   module OnlySubclasses 
     22  module Subclasses 
    2323    def self.included(base) #nodoc: 
    2424      base.send :include, Reloadable 
  • trunk/activesupport/test/reloadable_test.rb

    r3528 r3533  
    2626  end 
    2727   
    28   class OnlySubclassesReloadable 
    29     include Reloadable::OnlySubclasses 
     28  class SubclassesReloadable 
     29    include Reloadable::Subclasses 
    3030  end 
    31   class ASubclassOfOnlySubclassesReloadable < OnlySubclassesReloadable 
     31  class ASubclassOfSubclassesReloadable < SubclassesReloadable 
    3232  end 
    3333   
    3434  class AnOnlySubclassReloadableClassSubclassingAReloadableClass 
    35     include Reloadable::OnlySubclasses 
     35    include Reloadable::Subclasses 
    3636  end 
    3737   
     
    5252   
    5353  def test_only_subclass_reloadable 
    54     assert ! ReloadableTestSandbox::OnlySubclassesReloadable.reloadable? 
    55     assert ReloadableTestSandbox::ASubclassOfOnlySubclassesReloadable.reloadable? 
     54    assert ! ReloadableTestSandbox::SubclassesReloadable.reloadable? 
     55    assert ReloadableTestSandbox::ASubclassOfSubclassesReloadable.reloadable? 
    5656  end 
    5757   
     
    6767      AReloadableSubclass 
    6868      AClassWhichDefinesItsOwnReloadable 
    69       ASubclassOfOnlySubclassesReloadable 
     69      ASubclassOfSubclassesReloadable 
    7070    ) 
    7171    non_reloadables = %w( 
    7272      ANonReloadableSubclass 
    73       OnlySubclassesReloadable 
     73      SubclassesReloadable 
    7474    ) 
    7575