Changeset 1959

Timestamp:

07/31/05 09:16:21 (4 years ago)

Author:

minam

Message:

Fixed that Time#midnight would have a non-zero usec on some platforms #1836

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/time/calculations.rb (modified) (1 diff)
• trunk/activesupport/test/core_ext/time_ext_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fixed that Time#midnight would have a non-zero usec on some platforms #1836
-
-* Fixed inflections of "index/indices" #1766 [damn_pepe@gmail.com]

trunk/activesupport/lib/active_support/core_ext/time/calculations.rb

@@ -102 +102 @@
-        # Returns a new Time representing the start of the day (0:00)
-        def beginning_of_day
-self - self.seconds_since_midnight
+(self - self.seconds_since_midnight).change(:usec => 0)
-        end
-        alias :midnight :beginning_of_day

trunk/activesupport/test/core_ext/time_ext_test.rb

@@ -131 +131 @@
-    assert_equal Time.local(2005, 2, 21, 17, 44, 30), Time.local(2005, 2, 21, 17, 44, 30).to_time
-  end
+
+  # NOTE: this test seems to fail (changeset 1958) only on certain platforms,
+  # like OSX, and FreeBSD 5.4.
+  def test_fp_inaccuracy_ticket_1836
+    midnight = Time.local(2005, 2, 21, 0, 0, 0)
+    assert_equal midnight.midnight, (midnight + 1.hour + 0.000001).midnight
+  end
-end