Changeset 1223

Timestamp:

04/19/05 10:26:03 (3 years ago)

Author:

david

Message:

Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assignsperson? or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols.

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/assertions.rb (modified) (1 diff)
• trunk/actionpack/lib/action_view/base.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] won't work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but we've added a method-based accessor to appease the need for symbols.
-
-* Fixed that rendering a template would require a connection to the database #1146

trunk/actionpack/lib/action_controller/assertions.rb

@@ -15 +15 @@
-    # These collections can be used just like any other hash:
-    #
-[:person]
+(:person)
-    #   assert_equal "Dave", cookies[:name] # makes sure that a cookie called :name was set as "Dave"
-    #   assert flash.empty? # makes sure that there's nothing in the flash
+    #
+    # For historic reasons, the assigns hash uses string-based keys. So assigns[:person] won't work, but assigns["person"] will. To
+    # appease our yearning for symbols, though, an alternative accessor has been deviced using a method call instead of index referencing.
+    # So assigns(:person) will work just like assigns["person"], but again, assigns[:person] will not work.
-    #
-    # On top of the collections, you have the complete url that a given action redirected to available in redirect_to_url.

trunk/actionpack/lib/action_view/base.rb

@@ -158 +158 @@
-
-    def initialize(base_path = nil, assigns_for_first_render = {}, controller = nil)#:nodoc:
-.with_indifferent_access
+
-      @controller = controller
-    end