Ticket #9609: serialize_elements_patch_test.diff

test/unit/form.html

@@ -124 +124 @@
-      <input type="checkbox" id="ffe_ti2_checkbox" tabindex="0" />
-      <input type="submit" id="ffe_ti2_submit" tabindex="1" />
-    </form>
+    
+    <form id="trouble_form">
+        <input type="text" name="length" value="foo" />
+        <input type="text" name="toString" value="55" />
+        <input type="text" name="valueOf" value="bar" />
+    </form>
-  </div>
-
-  <!-- Tests follow -->
@@ -400 +406 @@
-                      $('form').serialize({ submit: false }));
-      assertHashEqual({ val1:4, action:'blah' },
-                      $('form').serialize({ submit: 'inexistent' }));
+    
+      // try to serialize form containing toString, valueOf and length -named elements
+      assertHashEqual({ length: 'foo', toString: 55, valueOf: 'bar' },
+                      $('trouble_form').serialize(true));
-    }},
-    
-    testFormMethodsOnExtendedElements: function() {with(this) {

src/form.js

@@ -14 +14 @@
-        key = element.name; value = $(element).getValue();
-        if (value != null && (element.type != 'submit' || (!submitted &&
-            submit !== false && (!submit || key == submit) && (submitted = true)))) { 
-
+ && !Object.isFunction(result[key])
-            // a key is already present; construct an array of values
-            if (!Object.isArray(result[key])) result[key] = [result[key]];
-            result[key].push(value);