Ticket #9137: dummy_time_parser_returns_nil.diff

activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb

@@ -124 +124 @@
-        end
-      end
-
+      # Returns a +Time+ whose date component is set to a dummy value, to represent
+      # the value of database columns of type +time+. These column types
+      # usually store only time-of-day information, but Ruby has no such
+      # time-only type.
+      #
+      # Returns a +Time+ corresponding to the parsed time-of-day on January 1, 2000,
+      # with <tt>Base.default_timezone</tt> appended, or +nil+ if the string input
+      # cannot be parsed.
-      def self.string_to_dummy_time(string)
-        return string unless string.is_a?(String)
-        return nil if string.empty?
-        time_hash = Date._parse(string)
+        return nil if time_hash.empty?
-        time_hash[:sec_fraction] = microseconds(time_hash)
-        # pad the resulting array with dummy date information
-        time_array = [2000, 1, 1]