Ticket #8730: gem_generators.patch

CHANGELOG

@@ -1 +1 @@
-*SVN*
-
+* Plugin generators can be placed in /rails_generators folder, in addition to /generators folder (in fact, any folder /*generators); to allow RubyGems with generators (see below) to be directly usable as plugins, and include generators. [Dr Nic, topfunky]
+
+* RubyGems can include Rails generators within /rails_generators/<generator_name>_generator.rb files (or /generators/... for generic generators), like you can do with plugins. GemSource renamed to GemGeneratorSource to free up meaningful namespace of Source subclasses [Dr Nic]
+
-* Fixed that dispatcher preparation callbacks only run once in production mode.  Mock Routes.reload so that dispatcher preparation callback tests run. [Rick]
-
-* Fix syntax error in dispatcher than wrecked failsafe responses.  #8625 [mtitorenko]

lib/rails_generator/scripts.rb

@@ -43 +43 @@
-
-          def usage_message
-            usage = "\nInstalled Generators\n"
-each do |
+inject({}) do |mem, 
-              label = source.label.to_s.capitalize
-
+
+
+
+
-              usage << "  #{label}: #{names.join(', ')}\n" unless names.empty?
-            end
-

lib/rails_generator/lookup.rb

@@ -46 +46 @@
-    #
-    # A spec is not a generator:  it's a description of where to find
-    # the generator and how to create it.  A source is anything that
-
+Generator
-    module Lookup
-      def self.included(base)
-        base.extend(ClassMethods)
@@ -100 +100 @@
-          if defined? ::RAILS_ROOT
-            sources << PathSource.new(:lib, "#{::RAILS_ROOT}/lib/generators")
-            sources << PathSource.new(:vendor, "#{::RAILS_ROOT}/vendor/generators")
-
+*
-          end
-          sources << PathSource.new(:user, "#{Dir.user_home}/.rails/generators")
-
+
+
+
+
-          sources << PathSource.new(:builtin, "#{File.dirname(__FILE__)}/generators/components")
-        end
-
@@ -185 +188 @@
-      end
-    end
-
-
-
-
-
+
-      def initialize
-        super :RubyGems
-      end
+    end
-
+    # GemGeneratorSource hits the mines to quarry for generators.  The latest versions
+    # of gems named *_generator are selected.
+    class GemGeneratorSource < AbstractGemSource
-      # Yield latest versions of generator gems.
-      def each
-        Gem::cache.search(/_generator$/).inject({}) { |latest, gem|
@@ -205 +209 @@
-      end
-    end
-
+    # GemPathSource looks for generators within any RubyGem's /rails_generators/<generator_name>_generator.rb file.
+    class GemPathSource < AbstractGemSource
+      # Yield each generator within rails_generator subdirectories.
+      def each
+        generator_full_paths.each do |generator|
+          yield Spec.new(File.basename(generator).sub(/_generator.rb$/, ''), File.dirname(generator), label)
+        end
+      end
+
+      private
+      def generator_full_paths
+        @generator_full_paths ||= 
+          begin
+            Gem::cache.inject({}) do |latest, name_gem|
+              name, gem = name_gem
+              hem = latest[gem.name]
+              latest[gem.name] = gem if hem.nil? or gem.version > hem.version
+              latest
+            end.values.inject([]) do |mem, gem|
+              Dir[gem.full_gem_path + '/{rails_,}generators/**/*_generator.rb'].each do |generator|
+                mem << generator
+              end
+              mem
+            end
+          end
+      end
+    end
+
-  end
-end

lib/rails_generator/spec.rb

@@ -2 +2 @@
-  module Generator
-    # A spec knows where a generator was found and how to instantiate it.
-    # Metadata include the generator's name, its base path, and the source
-
+Path
-    class Spec
-      attr_reader :name, :path, :source
-