Ticket #8713: always_construct_new_sql_on_save.patch

test/associations_test.rb

@@ -14 +14 @@
-require 'fixtures/comment'
-require 'fixtures/tag'
-require 'fixtures/tagging'
+require 'fixtures/person'
+require 'fixtures/reader'
-
-class AssociationsTest < Test::Unit::TestCase
-  fixtures :accounts, :companies, :developers, :projects, :developers_projects,
@@ -24 +26 @@
-      Class.new(ActiveRecord::Base).has_many(:wheels, :name => 'wheels')
-    end
-  end
+  
+  def test_should_construct_new_finder_sql_after_create
+    person = Person.new
+    assert_equal [], person.readers.find(:all)
+    person.save!
+    reader = Reader.create! :person => person, :post => Post.new(:title => "foo", :body => "bar")
+    assert_equal [reader], person.readers.find(:all)
+  end
-
-  def test_force_reload
-    firm = Firm.new("name" => "A New Firm, Inc")

lib/active_record/associations.rb

@@ -1083 +1083 @@
-              []
-            end
-
-if !
-  records_to_save.each { |record| association.send(:insert_record, record) }
-  association.send(:construct_sql)   
-end
+records_to_save.each { |record| association.send(:insert_record, record) } unless 
+
+
+association.send(:construct_sql) if association.respond_to?(:construct_sql)
-          end_eval
-
-          # Doesn't use after_save as that would save associations added in after_create/after_update twice