Ticket #8546: dont_escape_redirect_urls.diff

actionpack/test/controller/redirect_test.rb

@@ -37 +37 @@
-    redirect_to :action => "hello_world"
-  end
-
+  def redirect_to_url
+    redirect_to "http://www.rubyonrails.org/"
+  end
+
+  def redirect_to_url_with_unescaped_query_string
+    redirect_to "http://dev.rubyonrails.org/query?status=new"
+  end
+
-  def redirect_to_back
-    redirect_to :back
-  end
@@ -111 +119 @@
-    assert_equal "world", assigns["hello"]
-  end
-
+  def test_redirect_to_url
+    get :redirect_to_url
+    assert_response :redirect
+    assert_redirected_to "http://www.rubyonrails.org/"
+  end
+
+  def test_redirect_to_url_with_unescaped_query_string
+    get :redirect_to_url_with_unescaped_query_string
+    assert_response :redirect
+    assert_redirected_to "http://dev.rubyonrails.org/query?status=new"
+  end
+
-  def test_redirect_to_back
-    @request.env["HTTP_REFERER"] = "http://www.example.com/coming/from"
-    get :redirect_to_back

actionpack/test/template/prototype_helper_test.rb

@@ -314 +314 @@
-  def test_redirect_to
-    assert_equal 'window.location.href = "http://www.example.com/welcome";',
-      @generator.redirect_to(:action => 'welcome')
+    assert_equal 'window.location.href = "http://www.example.com/welcome?a=b&c=d";',
+      @generator.redirect_to("http://www.example.com/welcome?a=b&c=d")
-  end
-  
-  def test_delay

actionpack/lib/action_view/helpers/prototype_helper.rb

@@ -554 +554 @@
-          
-          # Redirects the browser to the given +location+, in the same form as +url_for+.
-          def redirect_to(location)
-
+
+
-          end
-          
-          # Calls the JavaScript +function+, optionally with the given +arguments+.