Ticket #8481: readAttribute.diff

test/unit/dom.html

@@ -228 +228 @@
-  <div foo="2"></div>
-</div>
-
-
+
+
-<a id="attributes_with_issues_2" href="" accesskey="" tabindex="" title=""></a>
-<a id="attributes_with_issues_3"></a>
-<form id="attributes_with_issues_form" method="post" action="blah">
@@ -1038 +1039 @@
-    
-    testElementReadAttribute: function() {with(this) {
-      assertEqual('test.html' , $('attributes_with_issues_1').readAttribute('href'));
-      
-      assertEqual('L' , $('attributes_with_issues_1').readAttribute('accesskey'));
-      assertEqual('50' , $('attributes_with_issues_1').readAttribute('tabindex'));
-      assertEqual('a link' , $('attributes_with_issues_1').readAttribute('title'));
-
+
+
+
+
+
+
+
-      ['href', 'accesskey', 'accesskey', 'title'].each(function(attr){
-        assertEqual('' , $('attributes_with_issues_2').readAttribute(attr));
-      });
@@ -1051 +1057 @@
-        assertEqual(attr, $('attributes_with_issues_'+attr).readAttribute(attr));
-      });
-      
+      assertEqual("alert('hello world');", $('attributes_with_issues_1').readAttribute('onclick'));
+      assertNull($('attributes_with_issues_1').readAttribute('onmouseover'));
+     
-      assertEqual('date', $('attributes_with_issues_type').readAttribute('type'));
-      assertEqual('text', $('attributes_with_issues_readonly').readAttribute('type'));
-      

src/dom.js

@@ -231 +231 @@
-  readAttribute: function(element, name) {
-    element = $(element);
-    if (Prototype.Browser.IE) {
-      if (!element.attributes) return null;
-      var t = Element._attributeTranslations.read;
-      if (t.values[name]) return t.values[name](element, name);
-
-
-
+
-    }    
-    return element.getAttribute(name);
-  },
@@ -743 +740 @@
-  Element._attributeTranslations = {
-    read: {
-      names: {
-
-
-
-
-
-
-
-
-
-
+
+
-      },
-      values: {
-        _getAttr: function(element, attribute) {
-          return element.getAttribute(attribute, 2);
-        },
+        _getEv: function(element, attribute) {
+          var attribute = element.getAttribute(attribute);
+          return attribute ? attribute.toString().slice(23, -2) : null;
+        },
-        _flag: function(element, attribute) {
-          return $(element).hasAttribute(attribute) ? attribute : null;
-        },
@@ -765 +758 @@
-          return element.style.cssText.toLowerCase();
-        },
-        title: function(element) {
-
-
+
-        }
-      }
-    }
@@ -774 +766 @@
-  
-  Element._attributeTranslations.write = {
-    names: Object.extend({
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
-    values: {
-      checked: function(element, value) {
-        element.checked = !!value;
@@ -788 +789 @@
-    }
-  };
-  
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-    });
-.call
+
-}
-
-else if (Prototype.Browser.Gecko) {

CHANGELOG

@@ -1 +1 @@
-*SVN*
-
+* Make Element#readAttribute work for cloned elements in IE. Closes #8481. [chem, Tobie Langel]
+
-* The action for Form#request defaults to the current URL if the "action" attribute is empty. (This is what most of the major browsers do.) Fixes #8483. [Tomas, Mislav Marohnić]
-
-* In form serialization, change the way submit buttons are handled. Previously all submit buttons were serialized; now Prototype serializes only the first one. Change Form#serialize and Form.serializeElements to accept a params hash. With the "hash: false" option, a serialized string is returned instead of the hash data object. With the "submit: 'foo'" option, only the submit button with the name "foo" is serialized.  References #5031.  [Mislav Marohnić]