Ticket #8308: xml_serialize.patch

test/core_ext/array_ext_test.rb

@@ -1 +1 @@
-require File.dirname(__FILE__) + '/../abstract_unit'
-require 'bigdecimal'
-
+module TestNamespace
+  class Model 
+    attr_accessor :id, :name
+
+    def initialize(id, name)
+      @id = id
+      @name = name
+    end
+
+    # hacked up to_xml for test purposes
+    # basically ignoring both options and block parameters
+    def to_xml(options = {}, &block)
+      "<test-namespace:model><id>#{@id}</id><name>#{@name}</name></test-namespace:model>"
+    end
+  end
+end
+
-class ArrayExtToParamTests < Test::Unit::TestCase
-  def test_string_array
-    assert_equal '', %w().to_param
@@ -179 +196 @@
-    assert_match(/^<\?xml [^>]*/, xml)
-    assert_equal 0, xml.rindex(/<\?xml /)
-  end
+
+  def test_to_xml_with_namespaced_class
+    xml = [TestNamespace::Model.new(1, 'MyName')].to_xml(:skip_instruct => true)
+    assert_match(/<test-namespace:models>/, xml)
+    assert_match(/<\/test-namespace:models>/, xml)
+  end
-end

lib/active_support/core_ext/array/conversions.rb

@@ -47 +47 @@
-        def to_xml(options = {})
-          raise "Not all elements respond to to_xml" unless all? { |e| e.respond_to? :to_xml }
-
-
+gsub(/\//, ':').
-          options[:children] ||= options[:root].singularize
-          options[:indent]   ||= 2
-          options[:builder]  ||= Builder::XmlMarkup.new(:indent => options[:indent])