Ticket #8277: add_reload_to_active_record_class_patch.diff

test/base_test.rb

@@ -1248 +1248 @@
-    t2.reload
-    assert_equal t1.title, t2.title
-  end
+  
+  def test_reload_multiple
+    t1 = Topic.find(1)
+    t2 = Topic.find(2)
+    t1.title = "something else"
+    t2.title = "something entirely new"
+    
+    Topic.connection.execute( "UPDATE #{Topic.table_name} 
+        SET title='something else'
+        WHERE id=1", 
+      "Updating records without ActiveRecord" )  
+    Topic.connection.execute( "UPDATE #{Topic.table_name} 
+        SET title='something entirely new' 
+        WHERE id=2", 
+      "Updating records without ActiveRecord" )  
+    
+    Topic.reload( [t1, t2] )
+    assert_equal "something else", t1.title
+    assert_equal "something entirely new", t2.title
+  end
-
-  def test_define_attr_method_with_value
-    k = Class.new( ActiveRecord::Base )

lib/active_record/base.rb

@@ -569 +569 @@
-        update_counters(id, counter_name => -1)
-      end
-
+      def reload(instances, options={})
+        return if instances.empty?
+        
+        new_instances = find_all_by_id( instances.map(&:id) )
+        instances.each_with_index do |instance, index|
+          instance.clear_aggregation_cache
+          instance.clear_association_cache
+          new_attrs = new_instances[index].instance_variable_get('@attributes')
+          instance.instance_variable_get( '@attributes' ).update( new_attrs )
+        end
+        
+      end
-
+
-      # Attributes named in this macro are protected from mass-assignment, such as <tt>new(attributes)</tt> and
-      # <tt>attributes=(attributes)</tt>. Their assignment will simply be ignored. Instead, you can use the direct writer
-      # methods to do assignment. This is meant to protect sensitive attributes from being overwritten by URL/form hackers. Example:
@@ -1715 +1728 @@
-      # may do e.g. record.reload(:lock => true) to reload the same record with
-      # an exclusive row lock.
-      def reload(options = nil)
-
-
-
+
-        self
-      end
-