Ticket #8241: remove_warning_in_validates_presence_of_docs.patch

lib/active_record/validations.rb

@@ -448 +448 @@
-      # * <tt>if</tt> - Specifies a method, proc or string to call to determine if the validation should
-      # occur (e.g. :if => :allow_validation, or :if => Proc.new { |user| user.signup_step > 2 }).  The
-      # method, proc or string should return or evaluate to a true or false value.
-      #
-      # === Warning
-      # Validate the presence of the foreign key, not the instance variable itself.
-      # Do this:
-      #  validates_presence_of :invoice_id
-      #
-      # Not this:
-      #  validates_presence_of :invoice
-      #
-      # If you validate the presence of the associated object, you will get
-      # failures on saves when both the parent object and the child object are
-      # new.
-      def validates_presence_of(*attr_names)
-        configuration = { :message => ActiveRecord::Errors.default_error_messages[:blank], :on => :save }
-        configuration.update(attr_names.pop) if attr_names.last.is_a?(Hash)

test/validations_test.rb

@@ -2 +2 @@
-require 'fixtures/topic'
-require 'fixtures/reply'
-require 'fixtures/person'
+require 'fixtures/reader'
-require 'fixtures/developer'
-
-# The following methods in Topic are used in test_conditional_validation_*
@@ -28 +29 @@
-    Topic.write_inheritable_attribute(:validate, nil)
-    Topic.write_inheritable_attribute(:validate_on_create, nil)
-    Topic.write_inheritable_attribute(:validate_on_update, nil)
+    
+    Reader.write_inheritable_attribute(:validate, nil)
+    Person.write_inheritable_attribute(:validate, nil)
-  end
-
-  def test_single_field_validation
@@ -276 +280 @@
-
-    assert t.save
-  end
+  
+  def test_validate_presence_of_belongs_to_association_with_unsaved_parent_and_child
+    Reader.validates_presence_of :person
+    
+    child = Reader.new(:post_id => '1')
+    assert !child.save
+    assert_equal "can't be blank", child.errors.on(:person)
+    
+    parent = child.person = Person.new()
+    assert child.new_record?
+    assert parent.new_record?
+    assert child.save
+  end
+  
+  def test_validate_presence_of_has_many_association_with_unsaved_parent_and_child
+    Person.validates_presence_of :readers
+    
+    parent = Person.new()
+    assert !parent.save
+    assert_equal "can't be blank", parent.errors.on(:readers)
+    
+    child = parent.readers = [Reader.new(:post_id => '1')]
+    assert parent.new_record?
+    assert parent.readers[0].new_record?
+    assert parent.save
+  end
-
-  def test_validate_uniqueness
-    Topic.validates_uniqueness_of(:title)