Ticket #7932: method_missing_for_table_definitions_by_extend.diff

activerecord/test/migration_test.rb

@@ -93 +93 @@
-      Person.connection.drop_table :testings rescue nil
-    end
-
+    def test_create_table_with_method_missing
+      Person.connection.create_table :testings do |t|
+        t.one :string
+        t.two :integer, :default => 2
+      end
+
+      columns = Person.connection.columns(:testings)
+
+      assert_equal %w(id one two), columns.map { |c| c.name }.sort
+      assert_equal 2, columns.find { |c| c.name == "two" }.default
+    ensure
+      Person.connection.drop_table :testings rescue nil
+    end
+
-    def test_create_table_with_not_null_column
-      assert_nothing_raised do
-        Person.connection.create_table :testings do |t|

activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -90 +90 @@
-      def create_table(name, options = {})
-        table_definition = TableDefinition.new(self)
-        table_definition.primary_key(options[:primary_key] || "id") unless options[:id] == false
+        extend_table_definition! table_definition
-
-        yield table_definition
-
@@ -298 +299 @@
-        def options_include_default?(options)
-          options.include?(:default) && !(options[:null] == false && options[:default].nil?)
-        end
+
+        def extend_table_definition!(table_definition)
+          class << table_definition
+            def method_missing(name, *args)
+              column(name, *args)
+            end
+          end
+        end
-    end
-  end
-end