Ticket #7372: test_session_indifferent_fixed_for_session_args.diff

test/controller/test_test.rb

@@ -3 +3 @@
-
-class TestTest < Test::Unit::TestCase
-  class TestController < ActionController::Base
+    def no_op
+      render :text => 'dummy'
+    end
+
-    def set_flash
-      flash["test"] = ">#{flash["test"]}<"
-      render :text => 'ignore me'
-    end
-
+    def set_session
+      session['string'] = 'A wonder'
+      session[:symbol] = 'it works'
+      render :text => 'Success'
+    end
+
-    def render_raw_post
-      raise Test::Unit::AssertionFailedError, "#raw_post is blank" if request.raw_post.blank?
-      render :text => request.raw_post
@@ -111 +121 @@
-    assert_equal '>value<', flash['test']
-  end
-
+  def test_process_with_session
+    process :set_session
+    assert_equal 'A wonder', session['string'], "A value stored in the session should be available by string key"
+    assert_equal 'A wonder', session[:string], "Test session hash should allow indifferent access"
+    assert_equal 'it works', session['symbol'], "Test session hash should allow indifferent access"
+    assert_equal 'it works', session[:symbol], "Test session hash should allow indifferent access"
+  end
+
+  def test_process_with_session_arg
+    process :no_op, nil, { 'string' => 'value1', :symbol => 'value2' }
+    assert_equal 'value1', session['string']
+    assert_equal 'value1', session[:string]
+    assert_equal 'value2', session['symbol']
+    assert_equal 'value2', session[:symbol]
+  end
+
-  def test_process_with_request_uri_with_no_params
-    process :test_uri
-    assert_equal "/test_test/test/test_uri", @response.body

lib/action_controller/test_process.rb

@@ -283 +283 @@
-
-    def initialize(attributes = nil)
-      @session_id = ''
-
+.nil? ? nil : attributes.stringify_keys
-      @saved_attributes = nil
-    end
-
@@ -292 +292 @@
-    end
-
-    def [](key)
-
+.to_s
-    end
-
-    def []=(key, value)
-
+.to_s
-    end
-
-    def update

CHANGELOG

@@ -1 +1 @@
-*SVN*
-
+* TestSession initializer also supports indifferent access when a session hash is passed to process.  #7632 [tamc, Arsen7, mhackett]
+
+* TestSession supports indifferent access so session['foo'] == session[:foo] in your tests.  #7372 [julik, jean.helou]
+
-* Prefer MIME constants to strings.  #7707 [Dan Kubb]
-
-* Allow array and hash query parameters. Array route parameters are converted/to/a/path as before.  #6765, #7047, #7462 [bgipsy, Jeremy McAnally, Dan Kubb, brendan]