Ticket #6868: make_postgres_honor_scale_and_precision.diff

lib/active_record/connection_adapters/postgresql_adapter.rb

@@ -318 +318 @@
-        notnull = options[:null] == false
-
-        # Add the column.
-
+, options[:precision], options[:scale]
-
-        # Set optional default. If not null, update nulls to the new default.
-        unless default.nil?

test/migration_test.rb

@@ -199 +199 @@
-    ensure
-      Person.connection.drop_table :testings rescue nil
-    end
+    
+    def test_add_column_with_precision_and_scale
+        Person.connection.add_column Person.table_name, :cost, :decimal, :precision => 3, :scale => 2
+        # Unfortunately it's very difficult to test whether the database engine actually raises
+        # StatementInvalid because this differs a lot between database engines and versions.
+        Person.reset_column_information
+        column = Person.columns.detect { |c| c.name == 'cost' }
+        assert_equal 3, column.precision
+        assert_equal 2, column.scale
+      ensure
+        Person.connection.remove_column Person.table_name, :cost rescue nil
+    end
-
-    # We specifically do a manual INSERT here, and then test only the SELECT
-    # functionality. This allows us to more easily catch INSERT being broken,