Ticket #6835: add-duration-to-date-time.diff

lib/active_support/core_ext/date.rb

@@ -1 +1 @@
-require 'date'
+require File.dirname(__FILE__) + '/date/calculations'
-require File.dirname(__FILE__) + '/date/conversions'
-
-class Date#:nodoc:
+  include ActiveSupport::CoreExtensions::Date::Calculations
-  include ActiveSupport::CoreExtensions::Date::Conversions
-end

lib/active_support/core_ext/numeric/time.rb

@@ -3 +3 @@
-    module Numeric #:nodoc:
-      # Enables the use of time calculations and declarations, like 45.minutes + 2.hours + 4.years.
-      #
-
-
+
+
+
+
+
+
+
+
+
+
+
-      # 
-
+
+
+
+
+
+
+
+
+
+
+
-      # Date[http://stdlib.rubyonrails.org/libdoc/date/rdoc/index.html] and 
-      # Time[http://stdlib.rubyonrails.org/libdoc/time/rdoc/index.html] should be used for precision
-      # date and time arithmetic
-      module Time
-        def seconds
-self
+Duration.new(self, [[:seconds, self]])
-        end
-        alias :second :seconds
-
-        def minutes
-self * 60
+Duration.new(self * 60, [[:seconds, self * 60]])
-        end
-        alias :minute :minutes  
-        
-        def hours
-self * 60.minutes
+Duration.new(self * 3600, [[:seconds, self * 3600]])
-        end
-        alias :hour :hours
-        
-        def days
-self * 24.hours
+Duration.new(self * 24.hours, [[:days, self]])
-        end
-        alias :day :days
-
-        def weeks
-self * 7.days
+Duration.new(self * 7.days, [[:days, self * 7]])
-        end
-        alias :week :weeks
-        
-        def fortnights
-self * 2.weeks
+Duration.new(self * 2.weeks, [[:days, self * 14]])
-        end
-        alias :fortnight :fortnights
-        
-        def months
-self * 30.days
+Duration.new(self * 30.days, [[:months, self]])
-        end
-        alias :month :months
-
-        def years
-(self * 365.25.days).to_i
+Duration.new(self * 365.25.days, [[:years, self]])
-        end
-        alias :year :years
-
@@ -67 +86 @@
-        # Reads best without arguments:  10.minutes.from_now
-        alias :from_now :since
-      end
+      
+      class Duration < Builder::BlankSlate
+        attr_accessor :value, :parts
+        
+        def initialize(value, parts)
+          @value, @parts = value, parts
+        end
+        
+        def +(other)
+          if Duration === other
+            Duration.new(value + other.value, @parts + other.parts)
+          else
+            Duration.new(value + other, @parts + [[:seconds, other]])
+          end
+        end
+        
+        def -(other)
+          self + (-other)
+        end
+        
+        def -@
+          Duration.new(-value, parts.map { |type,number| [type, -number] })
+        end
+        
+        def is_a?(klass)
+          klass == Duration || super
+        end
+        
+        def self.===(other)
+          other.is_a?(Duration) rescue super
+        end
+        
+        def since(time = ::Time.now)
+          sum(1, time)
+        end
+        alias :from_now :since
+        
+        def ago(time = ::Time.now)
+          sum(-1, time)
+        end
+        alias :until :ago
+        
+        def inspect
+          "(#{value}, #{parts.inspect})"
+        end
+        
+        protected
+        
+        def sum(sign, time = ::Time.now)
+          parts.inject(time) do |t,(type,number)|
+            case t
+            when ::Time
+              if type == :seconds
+                t + (sign * number)
+              else
+                t.advance(type => sign * number)
+              end
+            when ::Date
+              raise ArgumentError, "Adding seconds to a Date does not make sense" if type == :seconds
+              t.advance(type => sign * number)
+            end
+          end
+        end
+        
+        private
+        
+        def method_missing(method, *args, &block)
+          value.send(method, *args)
+        end
+      end
-    end
-  end
-end

lib/active_support/core_ext/time/calculations.rb

@@ -5 +5 @@
-      module Calculations
-        def self.included(base) #:nodoc:
-          base.extend(ClassMethods)
+          
+          base.send(:alias_method, :plus_without_duration, :+)
+          base.send(:alias_method, :+, :plus_with_duration)
+          base.send(:alias_method, :minus_without_duration, :-)
+          base.send(:alias_method, :-, :minus_with_duration)
-        end
-
-        module ClassMethods
@@ -190 +195 @@
-        def tomorrow
-          self.since(1.day)
-        end
+        
+        def plus_with_duration(other) #:nodoc:
+          if ActiveSupport::CoreExtensions::Numeric::Duration === other
+            other.since(self)
+          else
+            plus_without_duration(other)
+          end
+        end
+
+        def minus_with_duration(other) #:nodoc:
+          if ActiveSupport::CoreExtensions::Numeric::Duration === other
+            other.until(self)
+          else
+            minus_without_duration(other)
+          end
+        end
-      end
-    end
-  end

test/core_ext/numeric_ext_test.rb

@@ -34 +34 @@
-      assert seconds.from_now >= now + seconds
-    end
-  end
+  
+  def test_irregular_durations
+    assert_equal @now.advance(:days => 3000), 3000.days.since(@now)
+    assert_equal @now.advance(:months => 1), 1.month.since(@now)
+    assert_equal @now.advance(:months => -1), 1.month.until(@now)
+    assert_equal @now.advance(:years => 20), 20.years.since(@now)
+  end
+  
+  def test_duration_addition
+    assert_equal @now.advance(:days => 1, :months => 1), (1.day + 1.month).since(@now)
+    assert_equal @now.advance(:days => 7), (1.week + 5.seconds - 5.seconds).since(@now)
+    assert_equal @now.advance(:years => 2), (4.years - 2.years).since(@now)
+  end
+  
+  def test_time_plus_duration
+    assert_equal @now + 8, @now + 8.seconds
+    assert_equal @now + 22.9, @now + 22.9.seconds
+    assert_equal @now.advance(:days => 15), @now + 15.days
+    assert_equal @now.advance(:months => 1), @now + 1.month
+  end
+  
+  def test_duration_after_convertion_is_no_longer_accurate
+    assert_equal 30.days.to_i.since(@now), 1.month.to_i.since(@now)
+    assert_equal 365.25.days.to_f.since(@now), 1.year.to_f.since(@now)
+  end
-end
-
+class NumericExtDateTest < Test::Unit::TestCase
+  def setup
+    @today = Date.today
+  end
+
+  def test_date_plus_duration
+    assert_equal @today + 1, @today + 1.day
+    assert_equal @today >> 1, @today + 1.month
+    assert_raises(ArgumentError) { @today + 1.second }
+  end
+end
+
-class NumericExtSizeTest < Test::Unit::TestCase
-  def test_unit_in_terms_of_another
-    relationships = {