Ticket #6642: fragment_caching_for_non_erb_templates.2.diff

actionpack/lib/action_controller/caching.rb

@@ -359 +359 @@
-        name.is_a?(Hash) ? url_for(name).split("://").last : name
-      end
-
-      # Called by CacheHelper#cache
-      def cache_erb_fragment(block, name = {}, options = nil)
-        unless perform_caching then block.call; return end
-
-        buffer = eval(ActionView::Base.erb_variable, block.binding)
-
+      def fragment_for(block, name = {}, options = nil)
+        unless perform_caching then block.call; return end
+        buffer = yield
-        if cache = read_fragment(name, options)
-          buffer.concat(cache)
-        else
@@ -374 +372 @@
-        end
-      end
-
+      # Called by CacheHelper#cache
+      def cache_rxml_fragment(block, name = {}, options = nil)
+        fragment_for(block, name, options) do
+          eval('xml.target!', block.binding)
+        end
+      end
+
+      # Called by CacheHelper#cache
+      def cache_rjs_fragment(block, name = {}, options = nil)
+        fragment_for(block, name, options) do
+          begin
+            debug_mode, ActionView::Base.debug_rjs = ActionView::Base.debug_rjs, false
+            eval('page.to_s', block.binding)
+          ensure
+            ActionView::Base.debug_rjs = debug_mode
+          end
+        end
+      end
+
+      # Called by CacheHelper#cache
+      def cache_erb_fragment(block, name = {}, options = nil)
+        fragment_for(block, name, options) do
+          eval(ActionView::Base.erb_variable, block.binding)
+        end
+      end
+
-      def write_fragment(name, content, options = nil)
-        return unless perform_caching
-
@@ -618 +642 @@
-        # ActiveRecord::Observer will mark this class as reloadable even though it should not be.
-        # However, subclasses of ActionController::Caching::Sweeper should be Reloadable
-        include Reloadable::Deprecated
-
+
-        def before(controller)
-          self.controller = controller
-          callback(:before)

actionpack/lib/action_view/helpers/cache_helper.rb

@@ -32 +32 @@
-      #      <i>Topics listed alphabetically</i>
-      #    <% end %>
-      def cache(name = {}, &block)
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-      end
-    end
-  end

actionpack/test/controller/caching_test.rb

@@ -311 +311 @@
-      assert File.exist?(full_path), "#{full_path.inspect} does not exist."
-    end
-end
+
+class FragmentCachingTestController < ActionController::Base
+  def some_action; end;
+end
+
+class FragmentCachingTest < Test::Unit::TestCase
+  def setup
+    ActionController::Base.perform_caching = true
+    @store = ActionController::Caching::Fragments::UnthreadedMemoryStore.new
+    ActionController::Base.fragment_cache_store = @store
+    @controller = FragmentCachingTestController.new
+    @params = {:controller => 'posts', :action => 'index'}
+    @request = ActionController::TestRequest.new
+    @response = ActionController::TestResponse.new
+    @controller.params = @params
+    @controller.request = @request
+    @controller.response = @response
+    @controller.send(:initialize_current_url)
+  end
+
+  def test_fragement_cache_key
+    assert_equal 'dee zsombor', @controller.fragment_cache_key('dee zsombor')
+    assert_equal( "test.host/fragment_caching_test/some_action",
+                  @controller.fragment_cache_key(:controller => 'fragment_caching_test',:action => 'some_action'))
+  end
+
+  def test_read_fragment__with_caching_enabled
+    @store.write('name', 'value')
+    assert_equal 'value', @controller.read_fragment('name')
+  end
+
+  def test_read_fragment__with_caching_disabled
+    ActionController::Base.perform_caching = false
+    @store.write('name', 'value')
+    assert_nil @controller.read_fragment('name')
+  end
+
+  def test_write_fragment__with_caching_enabled
+    assert_nil @store.read('name')
+    assert_equal 'value', @controller.write_fragment('name', 'value')
+    assert_equal 'value', @store.read('name')
+  end
+
+  def test_write_fragment__with_caching_disabled
+    assert_nil @store.read('name')
+    ActionController::Base.perform_caching = false
+    assert_equal nil, @controller.write_fragment('name', 'value')
+    assert_nil @store.read('name')
+  end
+
+  def test_expire_fragment__with_simple_key
+    @store.write('name', 'value')
+    @controller.expire_fragment 'name'
+    assert_nil @store.read('name')
+  end
+
+  def test_expire_fragment__with__regexp
+    @store.write('name', 'value')
+    @store.write('another_name', 'another_value')
+    @store.write('primalgrasp', 'will not expire ;-)')
+
+    @controller.expire_fragment /name/
+
+    assert_nil @store.read('name')
+    assert_nil @store.read('another_name')
+    assert_equal 'will not expire ;-)', @store.read('primalgrasp')
+  end
+
+  def test_fragment_for__with_disabled_caching
+    ActionController::Base.perform_caching = false
+
+    @store.write('expensive', 'fragment content')
+    fragment_computed = false
+
+    buffer = 'generated till now -> '
+    @controller.fragment_for(Proc.new { fragment_computed = true }, 'expensive') { buffer }
+
+    assert fragment_computed
+    assert_equal 'generated till now -> ', buffer
+  end
+
+
+  def test_fragment_for
+    @store.write('expensive', 'fragment content')
+    fragment_computed = false
+
+    buffer = 'generated till now -> '
+    @controller.fragment_for(Proc.new { fragment_computed = true }, 'expensive') { buffer}
+
+    assert !fragment_computed
+    assert_equal 'generated till now -> fragment content', buffer
+  end
+
+  def test_cache_erb_fragment
+    @store.write('expensive', 'fragment content')
+    _erbout = 'generated till now -> '
+
+    assert_equal( 'generated till now -> fragment content',
+                  @controller.cache_erb_fragment(Proc.new{ }, 'expensive'))
+  end
+
+  def test_cache_rxml_fragment
+    @store.write('expensive', 'fragment content')
+    xml = 'generated till now -> '
+    class << xml; def target!; to_s; end; end
+
+    assert_equal( 'generated till now -> fragment content',
+                  @controller.cache_rxml_fragment(Proc.new{ }, 'expensive'))
+  end
+
+  def test_cache_rjs_fragment
+    @store.write('expensive', 'fragment content')
+    page = 'generated till now -> '
+
+    assert_equal( 'generated till now -> fragment content',
+                  @controller.cache_rjs_fragment(Proc.new{ }, 'expensive'))
+  end
+
+  def test_cache_rjs_fragment_debug_mode_does_not_interfere
+    @store.write('expensive', 'fragment content')
+    page = 'generated till now -> '
+
+    begin
+      debug_mode, ActionView::Base.debug_rjs = ActionView::Base.debug_rjs, true
+      assert_equal( 'generated till now -> fragment content',
+                    @controller.cache_rjs_fragment(Proc.new{ }, 'expensive'))
+      assert ActionView::Base.debug_rjs
+    ensure
+      ActionView::Base.debug_rjs = debug_mode
+    end
+  end
+end