Ticket #6569: assert_response_can_use_symbolic_status_codes.diff

lib/action_controller/assertions/response_assertions.rb

@@ -12 +12 @@
-      # * <tt>:error</tt>:  Status code was in the 500-599 range
-      #
-      # You can also pass an explicit status code number as the type, like assert_response(501)
+      # Supports symbolic status codes
-      def assert_response(type, message = nil)
-        clean_backtrace do
-          if [ :success, :missing, :redirect, :error ].include?(type) && @response.send("#{type}?")
-            assert_block("") { true } # to count the assertion
-          elsif type.is_a?(Fixnum) && @response.response_code == type
-            assert_block("") { true } # to count the assertion
+          elsif type.is_a?(Symbol) && @response.response_code == ActionController::StatusCodes::SYMBOL_TO_STATUS_CODE[type]
+            assert_block("") { true } # to count the assertion
-          else
-            assert_block(build_message(message, "Expected response to be a <?>, but was <?>", type, @response.response_code)) { false }
-          end