Ticket #591: stringify_keys.diff

test/core_ext/hash_ext_test.rb

@@ -15 +15 @@
-    assert_respond_to h, :symbolize_keys!
-    assert_respond_to h, :to_options
-    assert_respond_to h, :to_options!
+    assert_respond_to h, :stringify_keys
+    assert_respond_to h, :stringify_keys!
-  end
-
-  def test_symbolize_keys
@@ -33 +35 @@
-    assert_raises(NoMethodError) { { [] => 1 }.symbolize_keys! }
-  end
-
+  def test_stringify_keys
+    assert_equal @strings, @strings.stringify_keys
+    assert_equal @strings, @symbols.stringify_keys
+    assert_equal @strings, @mixed.stringify_keys
+
+    assert_raises(NoMethodError) { { [] => 1 }.symbolize_keys }
+  end
+
+  def test_stringify_keys!
+    assert_equal @strings, @strings.dup.stringify_keys!
+    assert_equal @strings, @symbols.dup.stringify_keys!
+    assert_equal @strings, @mixed.dup.stringify_keys!
+
+    assert_raises(NoMethodError) { { [] => 1 }.symbolize_keys! }
+  end
+
+
-  def test_assert_valid_keys
-    assert_nothing_raised do
-      { :failure => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ])

lib/core_ext/hash/keys.rb

@@ -21 +21 @@
-          end
-          self
-        end
+        
+        # Return a new hash with all keys converted to strings.
+        def stringify_keys
+          inject({}) {|options, (key, value)| options[key.to_s] = value; options}
+        end
+        # Destructively convert all keys to strings.
+        def stringify_keys!
+          keys.each do |key|
+            unless key.kind_of?(String)
+              self[key.to_s] = self[key]
+              delete key
+            end
+          end
+          self
+        end
-
-        alias_method :to_options,  :symbolize_keys
-        alias_method :to_options!, :symbolize_keys!