Ticket #5798: prototype_variable_name.diff

actionpack/test/template/prototype_helper_test.rb

@@ -57 +57 @@
-      periodically_call_remote(:update => "schremser_bier", :url => { :action => "mehr_bier" })
-  end
-  
+  def test_periodically_call_remote_with_variable_name
+    assert_dom_equal %(<script type="text/javascript">\n//<![CDATA[\nvar pe = new PeriodicalExecuter(function() {new Ajax.Updater('schremser_bier', 'http://www.example.com/mehr_bier', {asynchronous:true, evalScripts:true})}, 10)\n//]]>\n</script>),
+      periodically_call_remote(:update => "schremser_bier", :url => { :action => "mehr_bier" }, :name => "pe" )
+  end
+
-  def test_form_remote_tag
-    assert_dom_equal %(<form action=\"http://www.example.com/fast\" method=\"post\" onsubmit=\"new Ajax.Updater('glass_of_beer', 'http://www.example.com/fast', {asynchronous:true, evalScripts:true, parameters:Form.serialize(this)}); return false;\">),
-      form_remote_tag(:update => "glass_of_beer", :url => { :action => :fast  })

actionpack/lib/action_view/helpers/prototype_helper.rb

@@ -142 +142 @@
-      def periodically_call_remote(options = {})
-         frequency = options[:frequency] || 10 # every ten seconds by default
-         code = "new PeriodicalExecuter(function() {#{remote_function(options)}}, #{frequency})"
+         if name = options.delete(:name) then code = "var #{name} = " + code end
-         javascript_tag(code)
-      end
-