Ticket #5202: handle_empty_conditions.diff

activerecord/test/finder_test.rb

@@ -439 +439 @@
-    assert_equal [], Post.find(:all, :conditions => ['id in (?)', []])
-  end
-
+  def test_find_by_empty_conditions
+    assert Post.find(:first, :conditions => '')
+    assert Post.find(:first, :conditions => ['', nil])
+    assert Post.find(:first, :conditions => false)
+    assert Post.find(:first, :conditions => {})
+  end
+
-  def test_find_by_records
-    p1, p2 = Post.find(:all, :limit => 2, :order => 'id asc')
-    assert_equal [p1, p2], Post.find(:all, :conditions => ['id in (?)', [p1, p2]], :order => 'id asc')

activerecord/lib/active_record/base.rb

@@ -1160 +1160 @@
-          segments << sanitize_sql(conditions) unless conditions.nil?
-          segments << type_condition unless descends_from_active_record?        
-          segments.compact!
-empty?
+all?(&:blank?)
-        end
-
-        def type_condition