Ticket #3868: hide-show.diff

test/unit/dom.html

@@ -29 +29 @@
-      left: 10px;
-      top: 10px;
-    }
-
+
-  /* ]]> */
-  </style>
-</head>
@@ -62 +62 @@
-  </table>
-</div>
-
+<div id="visible">visible</div>
+<div id="hidden" style="display:none;">hidden</div>
+<div id="hidden-by-css">hidden</div>
+
+<div id="toggle-visible">visible</div>
+<div id="toggle-hidden" style="display:none;">hidden</div>
+
+<div id="hide-visible">visible</div>
+<div id="hide-hidden" style="display:none;">hidden</div>
+<div id="visibility-inline" style="display:inline;">inline</div>
+
+<div id="show-visible">visible</div>
+<div id="show-hidden" style="display:none;">hidden</div>
+
-<p class="test">Test paragraph outside of container</p>
-
-<div id="container">
@@ -185 +199 @@
-      assert($('second_row').childOf('table'));
-    }},
-    
+    testVisible: function() {with(this) {
+      assert($('visible').visible());
+      assert(!$('hidden').visible());
+      assert($('hidden-by-css').visible());
+    }},
+    
+    testToggle: function() {with(this) {
+      $('toggle-visible').toggle();
+      assert(!$('toggle-visible').visible());
+      $('toggle-visible').toggle();
+      assert($('toggle-visible').visible());
+      $('toggle-hidden').toggle();
+      assert($('toggle-hidden').visible());
+      $('toggle-hidden').toggle();
+      assert(!$('toggle-hidden').visible());
+    }},
+    
+    testHide: function() {with(this) {
+      $('hide-visible').hide();
+      assert(!$('hide-visible').visible());
+      assertUndefined($('hide-visible')._originalDisplay);
+      
+      $('hide-hidden').hide();
+      assert(!$('hide-hidden').visible());
+      assertUndefined($('hide-visible')._originalDisplay);
+    }},
+    
+    testShow: function() {with(this) {      
+      $('show-hidden').show();
+      assert($('show-hidden').visible());      
+      assertEqual('', $('show-visible').style.display);
+
+      $('show-visible').show();
+      assert($('show-visible').visible());
+      assertEqual('', $('show-visible').style.display);
+    }},
+    
+    testHideAndShowWithOtherInlineDisplayValue: function() {with(this) {
+      $('visibility-inline').hide();
+      assert(!$('visibility-inline').visible());
+      assertEqual('inline', $('visibility-inline')._originalDisplay);
+      $('visibility-inline').show();
+      assert($('visibility-inline').visible());
+      assertEqual('inline', $('visibility-inline').style.display);
+      assertNull($('visibility-inline')._originalDisplay);
+      
+      $('visibility-inline').setStyle({display: 'block'});
+      
+      $('visibility-inline').hide();
+      assert(!$('visibility-inline').visible());
+      assertEqual('block', $('visibility-inline')._originalDisplay);
+      $('visibility-inline').show();
+      assert($('visibility-inline').visible());
+      assertEqual('block', $('visibility-inline').style.display);
+      assertNull($('visibility-inline')._originalDisplay);      
+    }},
+    
-    testElementUpdate: function() {with(this) {
-      $('testdiv').update('hello from div!');
-      assertEqual('hello from div!', $('testdiv').innerHTML);

src/dom.js

@@ -85 +85 @@
-  },
-
-  hide: function(element) {
-
+
+
+
+
+
-    return element;
-  },
-
+
-  show: function(element) {
-
+
+
+
+
+
-    return element;
-  },
-