Ticket #3717: InPlaceEditorSubmitOnBlurCrashOnSafari.diff

src/controls.js

@@ -669 +669 @@
-      var size = this.options.size || this.options.cols || 0;
-      if (size != 0) textField.size = size;
-      if (this.options.submitOnBlur)
-Submit
+Blur
-      this.editField = textField;
-    } else {
-      this.options.textarea = true;
@@ -681 +681 @@
-      textArea.cols = this.options.cols || 40;
-      textArea.className = 'editor_field';      
-      if (this.options.submitOnBlur)
-Submit
+Blur
-      this.editField = textArea;
-    }
-    
@@ -723 +723 @@
-    }
-    return false;
-  },
+  onBlur: function() {
+    // needed to prevent crash on Safari when clicking focus ring.
+    setTimeout(function() {
+      // Both okButton and cancelLink fires onblur event (cause duplicate submit), 
+      // so sanity check before submitting. 
+      if (!this.form || this.saving) return false;
+      this.onSubmit();
+    }.bind(this), 100);
+  },
-  onSubmit: function() {
-    // onLoading resets these so we need to save them away for the Ajax call
-    var form = this.form;