Ticket #3568: prototype_helper_behavior_methods_patch.diff

actionpack/test/template/prototype_helper_test.rb

@@ -111 +111 @@
-    assert_dom_equal %(<script type=\"text/javascript\">\n//<![CDATA[\nnew Form.Observer('cart', 2, function(element, value) {new Ajax.Request('http://www.example.com/cart_changed', {asynchronous:true, evalScripts:true})})\n//]]>\n</script>),
-      observe_form("cart", :frequency => 2, :url => { :action => "cart_changed" })
-  end
+  
+  def test_observe_elements
+    assert_equal %(new Behavior("a", {name: "show_href_on_click", callbacks: [function(element) {Event.observe(element, "click", function() {alert(element.href)});}]});),
+      observe_elements("a", {:click => "alert(element.href)"}, :name => "show_href_on_click")
+  end
+  
+  def test_register_behaviors
+    assert_equal %(new Behavior("a", {name: "a", callbacks: [function(element) {if (/\\.pdf$/i.test(element.href)) element.target = "_blank";}]});),
+      register_behaviors('a' => 'if (/\.pdf$/i.test(element.href)) element.target = "_blank";')
+  end
-
-  def test_update_element_function
-    assert_equal %($('myelement').innerHTML = 'blub';\n),

actionpack/lib/action_view/helpers/prototype_helper.rb

@@ -365 +365 @@
-        end
-      end
-      
+      # Applies callbacks for all elements matching the given CSS selector. For example,
+      # to make all +h1+ tags green on mouseover you could do this:
+      #
+      #   observe_elements 'h1',
+      #                    :mouseover => 'Element.setStyle(element, {color: "green"})',
+      #                    :mouseout  => 'Element.setStyle(element, {color: null})'
+      #
+      # Event names may optionally start with 'on'.
+      def observe_elements(selector, callbacks, options={})
+        options = {
+          :callback => (callbacks || {}).map { |(event,callback)|
+            %(Event.observe(element, #{event.to_s.sub(/^on/, '').to_json}, function() {#{callback}});)
+          } * "\n",
+          :name => selector
+        }.merge(options)
+
+        register_behaviors(selector => options)
+      end
+
+      # Applies behaviors to elements matching certain CSS selectors. For example,
+      # to make all paragraph elements fade in you could do this:
+      # 
+      #   register_behaviors 'p' => visual_effect(:appear)
+      #
+      # Or to make all links to PDF documents open in a new window:
+      #
+      #   register_behaviors 'a' => 'if (/\.pdf$/i.test(element.href)) element.target = "_blank";'
+      def register_behaviors(rules)
+        js = []
+        rules.dup.each do |(selector,options)|
+          options = {:name => selector, :callbacks => [options].flatten} unless options.is_a? Hash
+          options[:callbacks] ||= [options.delete(:callback)]
+          options[:callbacks].map! { |callback| "function(element) {#{callback}}" }
+          
+          js << "new Behavior(#{selector.to_json}, {name: #{options[:name].to_json}, callbacks: [#{options[:callbacks] * ','}]});"
+        end
+        js * "\n"
+      end
+
-      # JavaScriptGenerator generates blocks of JavaScript code that allow you 
-      # to change the content and presentation of multiple DOM elements.  Use 
-      # this in your Ajax response bodies, either in a <script> tag or as plain
@@ -501 +540 @@
-          yield
-          record "}, #{(seconds * 1000).to_i})"
-        end
-
+
+
+
+
+
+
+
+
-      private
-        def method_missing(method, *arguments, &block)
-          record(@context.send(method, *arguments, &block))