Ticket #3335: action_caching_for_non_success_status_codes.diff

actionpack/test/controller/caching_test.rb

@@ -94 +94 @@
-end
-
-class ActionCachingTestController < ActionController::Base
-
+, :redirected, :forbidden
-
-  def index
-    @cache_this = Time.now.to_f.to_s
-    render :text => @cache_this
-  end
-
+  def redirected
+    redirect_to :action => 'index'
+  end
+
+  def forbidden
+    render :text => "..."
+    headers["Status"] = "403 Forbidden"
+  end
+
-  def expire
-    expire_action :controller => 'action_caching_test', :action => 'index'
-    render :nothing => true
@@ -192 +201 @@
-    assert_equal david_cache, @response.body
-  end
-
+  def test_redirect_not_cached
+    get :redirected
+    assert_response :redirect
+    reset!
+    
+    get :redirected
+    assert_response :redirect
+  end
+
+  def test_forbidden_not_cached
+    get :forbidden
+    assert_response :forbidden
+    reset!
+
+    get :forbidden
+    assert_response :forbidden
+  end    
+
-  def test_xml_version_of_resource_is_treated_as_different_cache
-    @mock_controller.mock_url_for = 'http://example.org/posts/'
-    @mock_controller.mock_path    = '/posts/index.xml'

actionpack/lib/action_controller/caching.rb

@@ -202 +202 @@
-        end
-
-        def after(controller)
-
+
+
-          controller.write_fragment(ActionCachePath.path_for(controller), controller.response.body)
-        end
-