Ticket #3313: radio_button_generates_unique_id_with_negative_values.2.diff

actionpack/test/template/form_helper_test.rb

@@ -125 +125 @@
-  def test_radio_button_is_checked_with_integers
-    assert_dom_equal('<input checked="checked" id="post_secret_1" name="post[secret]" type="radio" value="1" />',
-      radio_button("post", "secret", "1")
-
+
+
+
+
+
+
+
-  end
-
+
-  def test_radio_button_respects_passed_in_id
-     assert_dom_equal('<input checked="checked" id="foo" name="post[secret]" type="radio" value="1" />',
-       radio_button("post", "secret", "1", :id=>"foo")

actionpack/lib/action_view/helpers/form_helper.rb

@@ -289 +289 @@
-          checked = self.class.radio_button_checked?(value(object), tag_value)
-        end
-        options["checked"]  = "checked" if checked
-
+(?!-)
-        options["id"]     ||= defined?(@auto_index) ?             
-          "#{@object_name}_#{@auto_index}_#{@method_name}_#{pretty_tag_value}" :
-          "#{@object_name}_#{@method_name}_#{pretty_tag_value}"