Ticket #11539: patch.diff

a/actionpack/lib/action_controller/request.rb

@@ -421 +421 @@
-    class << self
-      def parse_query_parameters(query_string)
-        return {} if query_string.blank?
-
+
+
-        pairs = query_string.split('&').collect do |chunk|
-          next if chunk.empty?
-          key, value = chunk.split('=', 2)

a/actionpack/test/controller/request_test.rb

@@ -447 +447 @@
-    @query_string_with_many_ampersands =
-      "&action=create_customer&&&full_name=David%20Heinemeier%20Hansson"
-    @query_string_with_empty_key = "action=create_customer&full_name=David%20Heinemeier%20Hansson&=Save"
+    @query_string_with_amp_chars = "action=create_customer&full_name=David"
-  end
-
-  def test_query_string
@@ -456 +457 @@
-    )
-  end
-
+  def test_query_string_with_amp_chars
+    assert_equal(
+      { "action" => "create_customer", "full_name" => "David"},
+      ActionController::AbstractRequest.parse_query_parameters(@query_string_with_amp_chars)
+    )
+  end
+
-  def test_deep_query_string
-    expected = {'x' => {'y' => {'z' => '10'}}}
-    assert_equal(expected, ActionController::AbstractRequest.parse_query_parameters('x[y][z]=10'))